-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lifecycle bot #209
lifecycle bot #209
Conversation
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
/cc @jonahjon |
lgtm |
/lgtm |
LGTM label has been added. Git tree hash: 58f30763cb299b28a5380c815830aed751b2f9a8
|
Is there any benefit to this?
Not sure how this is currently setup, but seems like a good idea. The prow job's look good either way, maybe moving interval up slightly from 1h to like 6h would be the only change I'd make. |
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
IMHO, not in this case :)
It's a Github App (to be precise) in the settings of the whole organisation (if I don't remember it wrong).
Thanks Jonah! |
/lgtm |
LGTM label has been added. Git tree hash: 7bc3d757c08cfd306916d94c941299f3a688086a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, jonahjon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@leodido: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #40 (where you can find detailed information about the resulting behavior of these 2 periodic
ProwJob
s.)The lifecycle transitions are:
WIP because some points are still open:
commenter
image?