Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifecycle bot #209

Merged
merged 4 commits into from
Nov 17, 2020
Merged

lifecycle bot #209

merged 4 commits into from
Nov 17, 2020

Conversation

leodido
Copy link
Member

@leodido leodido commented Nov 17, 2020

Fixes #40 (where you can find detailed information about the resulting behavior of these 2 periodic ProwJobs.)

The lifecycle transitions are:

  1. issue or PR becomes stale after 90 days of inactivity
  2. stale issue or PR becomes rotten after 30 days of inactivity
  3. rotten issues close after 30 days of inactivity

WIP because some points are still open:

  • should we build and publish our commenter image?
  • disable existing GitHub stale bot action

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
Copy link
Member Author

leodido commented Nov 17, 2020

/cc @jonahjon

@jonahjon
Copy link
Contributor

lgtm

@jonahjon
Copy link
Contributor

/lgtm

@poiana
Copy link
Contributor

poiana commented Nov 17, 2020

LGTM label has been added.

Git tree hash: 58f30763cb299b28a5380c815830aed751b2f9a8

@jonahjon
Copy link
Contributor

should we build and publish our commenter image?

Is there any benefit to this?

disable existing GitHub stale bot action

Not sure how this is currently setup, but seems like a good idea.

The prow job's look good either way, maybe moving interval up slightly from 1h to like 6h would be the only change I'd make.

jonahjon
jonahjon previously approved these changes Nov 17, 2020
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
Copy link
Member Author

leodido commented Nov 17, 2020

Is there any benefit to this?

IMHO, not in this case :)
But I wanted your opinion!

Not sure how this is currently setup, but seems like a good idea.

It's a Github App (to be precise) in the settings of the whole organisation (if I don't remember it wrong).
We need to think how to let all the test-infra-maintainers handle such things.

The prow job's look good either way, maybe moving interval up slightly from 1h to like 6h would be the only change I'd make.

Thanks Jonah!

@jonahjon
Copy link
Contributor

/lgtm

@poiana poiana added the lgtm label Nov 17, 2020
@poiana
Copy link
Contributor

poiana commented Nov 17, 2020

LGTM label has been added.

Git tree hash: 7bc3d757c08cfd306916d94c941299f3a688086a

@poiana
Copy link
Contributor

poiana commented Nov 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, jonahjon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit f48db04 into master Nov 17, 2020
@poiana poiana deleted the new/lifecycle-bot branch November 17, 2020 17:05
@poiana
Copy link
Contributor

poiana commented Nov 17, 2020

@leodido: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key periodic-close.yaml using file config/jobs/lifecycle-bot/periodic-close.yaml
  • key periodic-rotten.yaml using file config/jobs/lifecycle-bot/periodic-rotten.yaml
  • key periodic-stale.yaml using file config/jobs/lifecycle-bot/periodic-stale.yaml

In response to this:

Fixes #40 (where you can find detailed information about the resulting behavior of these 2 periodic ProwJobs.)

The lifecycle transitions are:

  1. issue or PR becomes stale after 90 days of inactivity
  2. stale issue or PR becomes rotten after 30 days of inactivity
  3. rotten issues close after 30 days of inactivity

WIP because some points are still open:

  • should we build and publish our commenter image?
  • disable existing GitHub stale bot action

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lifecycle bot
4 participants