Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin sdk go jobs #515

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Add plugin sdk go jobs #515

merged 2 commits into from
Sep 21, 2021

Conversation

mstemm
Copy link
Contributor

@mstemm mstemm commented Sep 20, 2021

This adds prow/poiana support for falcosecurity/plugin-sdk-go.

@poiana poiana added the size/M label Sep 20, 2021
@mstemm mstemm mentioned this pull request Sep 20, 2021
Closed
16 tasks
@leogr
Copy link
Member

leogr commented Sep 21, 2021

/assign

leogr
leogr reviewed Sep 21, 2021
View reviewed changes
config/config.yaml Outdated Show resolved Hide resolved
leogr
leogr reviewed Sep 21, 2021
View reviewed changes
Copy link
Member

@leogr leogr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mstemm
I have just found another small issue

config/config.yaml Outdated Show resolved Hide resolved
@mstemm
Add a job that can do a go test in plugin-sdk-go
e1ab074 
The module will really be tested when used by other plugins but go
test does at least do a build and build the examples.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
@mstemm
Add prow config for falcosecurity/plugin-sdk-go
c965dd0 
Following the example of
#314.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
@poiana poiana added the lgtm label Sep 21, 2021
@poiana
Copy link
Contributor

poiana commented Sep 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonahjon, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Sep 21, 2021

LGTM label has been added.

Git tree hash: a198ec0b155c251ad92de83c1d40a4b9aa570162

@poiana poiana merged commit 484b8fe into master Sep 21, 2021
@poiana poiana deleted the add-plugin-sdk-go-jobs branch September 21, 2021 18:04
@poiana
Copy link
Contributor

poiana commented Sep 21, 2021

@mstemm: Updated the following 3 configmaps:

  • config configmap in namespace default at cluster default using the following files:
    • key config.yaml using file config/config.yaml
  • job-config configmap in namespace default at cluster default using the following files:
    • key build-plugin-sdk-go.yaml using file config/jobs/build-plugin-sdk-go/build-plugin-sdk-go.yaml
  • plugins configmap in namespace default at cluster default using the following files:
    • key plugins.yaml using file config/plugins.yaml

In response to this:

This adds prow/poiana support for falcosecurity/plugin-sdk-go.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mstemm added a commit that referenced this pull request Apr 5, 2022
@mstemm
Add support for falco-aws-terraform repo
86e12c4 
Following the example of
https://github.com/falcosecurity/test-infra#create-a-presubmits-job-that-runs-tests-on-prs
and #515.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
@mstemm mstemm mentioned this pull request Apr 5, 2022
Merged
mstemm added a commit that referenced this pull request Apr 5, 2022
@mstemm
Add support for falco-aws-terraform repo
0351761 
Following the example of
https://github.com/falcosecurity/test-infra#create-a-presubmits-job-that-runs-tests-on-prs
and #515.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
poiana pushed a commit that referenced this pull request Apr 8, 2022
@mstemm @poiana
Add support for falco-aws-terraform repo
ed81e40 
Following the example of
https://github.com/falcosecurity/test-infra#create-a-presubmits-job-that-runs-tests-on-prs
and #515.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
maxgio92 pushed a commit to falcosecurity-test/test-infra that referenced this pull request Apr 23, 2022
@mstemm @maxgio92
Add support for falco-aws-terraform repo
a051dae 
Following the example of
https://github.com/falcosecurity/test-infra#create-a-presubmits-job-that-runs-tests-on-prs
and falcosecurity#515.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
maxgio92 pushed a commit to falcosecurity-test/test-infra that referenced this pull request Apr 23, 2022
@mstemm @maxgio92
Add support for falco-aws-terraform repo
2f3ccdb 
Following the example of
https://github.com/falcosecurity/test-infra#create-a-presubmits-job-that-runs-tests-on-prs
and falcosecurity#515.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
maxgio92 pushed a commit to falcosecurity/evolution that referenced this pull request Sep 8, 2022
@mstemm @maxgio92
Add support for falco-aws-terraform repo
06462b7 
Following the example of
https://github.com/falcosecurity/test-infra#create-a-presubmits-job-that-runs-tests-on-prs
and falcosecurity/test-infra#515.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
maxgio92 pushed a commit to falcosecurity/evolution that referenced this pull request Sep 22, 2022
@mstemm @maxgio92
Add support for falco-aws-terraform repo
5d8e741 
Following the example of
https://github.com/falcosecurity/test-infra#create-a-presubmits-job-that-runs-tests-on-prs
and falcosecurity/test-infra#515.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
maxgio92 pushed a commit to falcosecurity/evolution that referenced this pull request Sep 22, 2022
@mstemm @maxgio92
Add support for falco-aws-terraform repo
11ceb18 
Following the example of
https://github.com/falcosecurity/test-infra#create-a-presubmits-job-that-runs-tests-on-prs
and falcosecurity/test-infra#515.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
maxgio92 pushed a commit to falcosecurity/evolution that referenced this pull request Jan 17, 2023
@mstemm @maxgio92
Add support for falco-aws-terraform repo
e71fdea 
Following the example of
https://github.com/falcosecurity/test-infra#create-a-presubmits-job-that-runs-tests-on-prs
and falcosecurity/test-infra#515.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
maxgio92 pushed a commit to maxgio92/evolution that referenced this pull request May 26, 2023
@mstemm @maxgio92
Add support for falco-aws-terraform repo
686dfae 
Following the example of
https://github.com/falcosecurity/test-infra#create-a-presubmits-job-that-runs-tests-on-prs
and falcosecurity/test-infra#515.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
maxgio92 pushed a commit to maxgio92/evolution that referenced this pull request Jun 20, 2023
@mstemm @maxgio92
Add support for falco-aws-terraform repo
af06a79 
Following the example of
https://github.com/falcosecurity/test-infra#create-a-presubmits-job-that-runs-tests-on-prs
and falcosecurity/test-infra#515.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr left review comments

@jonahjon jonahjon jonahjon approved these changes

@maxgio92 maxgio92 Awaiting requested review from maxgio92

Assignees

@leogr leogr

@jonahjon jonahjon

Labels
approved dco-signoff: yes lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mstemm @leogr @poiana @jonahjon