Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(action): increase tests timeout #57

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 13, 2024

Also, properly upload full txt report that is actually the tests-generated output before the go-junit-report parsing.

@FedeDP FedeDP changed the title wip chore(action): increase tests timeout May 13, 2024
Also, upload text version of report, that actually contains tests output.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@@ -116,4 +120,6 @@ runs:
uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
with:
name: falcosecurity-testing-report-${{ runner.arch }}
path: ${{ steps.store-outputs.outputs.report }}
path: |
${{ steps.store-outputs.outputs.report }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Store both generated report and actual tests output.

Copy link
Collaborator

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit e3fcfc1 into falcosecurity:main May 13, 2024
3 checks passed
@FedeDP FedeDP deleted the wip branch May 13, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants