Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a docker image reference the .nvmrc version #154

Open
falgon opened this issue Jun 12, 2021 · 3 comments
Open

Make a docker image reference the .nvmrc version #154

falgon opened this issue Jun 12, 2021 · 3 comments
Assignees
Projects

Comments

@falgon
Copy link
Owner

falgon commented Jun 12, 2021

Improvements to use nvmrc have been made in #153, but are currently fixed to use node version 14 for docker image creation. i.e.

&& curl -sSL https://deb.nodesource.com/setup_14.x | bash \

It needs to be improved to refer to .nvmrc even when creating a docker image, but I do not use it so much, so it may not be necessary to take immediate action.

@falgon falgon added the task label Jun 12, 2021
@falgon falgon self-assigned this Jun 12, 2021
@falgon
Copy link
Owner Author

falgon commented Jun 12, 2021

Articles that may be helpful: https://zenn.dev/uttk/articles/a7b085c7774ae9

@falgon falgon added this to To do in roki-web Jul 6, 2021
@falgon falgon changed the title Make docker image reference the .nvmrc version Make a docker image reference the .nvmrc version Aug 1, 2022
@falgon
Copy link
Owner Author

falgon commented Aug 1, 2022

#305

@falgon falgon moved this from To do to In progress in roki-web Aug 1, 2022
@falgon falgon added the CI label Dec 16, 2022
@falgon
Copy link
Owner Author

falgon commented Feb 3, 2023

#315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
roki-web
In progress
Development

No branches or pull requests

1 participant