Small fix #23
Merged
Small fix #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome 👍 👍 👍 |
|
Why not send random client IDs? |
|
@PEMapModder I think that would be preferred behaviour in most cases. You can PR if you want. |
|
Random client ID? What would the ranges be? What happens if the same number is drawn twice? I still think using the name is better. |
|
@GameCrafter the same number is drawn twice? You will see that once in a blue moon. |
|
So what are the minimum and maximum numbers? |
|
@GameCrafter is correct. We wouldn't want to introduce that collision issue especially with PHP's crappy random number system. The behaviour would be undefined. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Specters not being able to log in with identical UUIDs, more commonly known as not being able to spawn multiple Specters.