Log marketo response errors #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds zombie removal tool * Corrects endpoint adds comments * Adds API links * Changes search logic, fixes escape character * Corrects help text
Make sure the sourceCatalogId field is set with the value stored in the database.
* Improve Gradle build and fix storybook * Run all copy tasks after copyDocker
…q#13703) * save streams to reset in job config when creating reset job * change streamDescriptors to streamsToReset
…mental sync (airbytehq#13655) * Postgres Source: fixed unsupposted date-time datatypes during incremental sync * updated CHANGELOG * add tests for incremental cursor check * removed star import * Postgres Source: fixed unsupposted date-time datatypes during incremental sync * updated CHANGELOG * add tests for incremental cursor check * removed star import * add timestamp datatype test * Bump version in Dockerfile * auto-bump connector version Co-authored-by: grishick <greg@airbyte.io> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
…#13728) * Fail the connection state instead of throwin exception * Fix test * rm import * Update airbyte-workers/src/main/java/io/airbyte/workers/general/DefaultCheckConnectionWorker.java Co-authored-by: Evan Tahler <evan@airbyte.io> Co-authored-by: Evan Tahler <evan@airbyte.io>
* add a couple of unit tests * refactor tests
…3722) * Update Databricks naming * Update destination_spec * Update BOOTSTRAP.md * Update Dockerfile * Update README.md * Update spec.json * Update databricks.md * Update databricks.md * Update airbyte-integrations/connectors/destination-databricks/BOOTSTRAP.md Co-authored-by: LiRen Tu <tuliren.git@outlook.com> Co-authored-by: LiRen Tu <tuliren.git@outlook.com>
… case DateTimeParseException is thrown (airbytehq#13745) * Fall back to parsing w/ or w/o TZ if parsing a date or a time string fails * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
…-postgres version (airbytehq#13747)
…uet formats (airbytehq#13483) * S3 destination: Updating processing data types for Avro/Parquet formats * S3 destination: handle comparing data types * S3 destination: clean code * S3 destination: clean code * S3 destination: handle case with unexpected json schema type * S3 destination: clean code * S3 destination: Extract the same logic for Avro/Parquet formats to separate parent class * S3 destination: clean code * S3 destination: clean code * GCS destination: Update data types processing for Avro/Parquet formats * GCS destination: clean redundant code * S3 destination: handle case with numbers inside array * S3 destination: clean code * S3 destination: add unit test * S3 destination: update unit test cases with number types. * S3 destination: update unit tests. * S3 destination: bump version for s3 and gcs * auto-bump connector version * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
…e size (airbytehq#13658) * change logic for counting records * update doc * correct unit test * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
* Create interface, factory for metric client * remove unused func * change count val to use long * PR fix * otel metric client implementation * merge conflicts resolve * build fix * add a test, moved version into deps catalog * fix test * add docs for open telemetry * fix kube setting for otel, and add doc * helm related fields update for opentel
…3759) Co-authored-by: benmoriceau <benmoriceau@users.noreply.github.com> Co-authored-by: Benoit Moriceau <benoit@airbyte.io>
…iseconds or seconds is 0 (airbytehq#13549) * Postgres Source: fixed truncated precision if the value of the millisecond or second is 0 * check CI with 1.15.3 testcontainer * check CI with 1.15.3 testcontainer * returned latest version of testcontainer * fixed checkstyle * fixed checkstyle * returned latest testcontainer version * updated CHANGELOG * bump version * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
…ytehq#13769) * Postgres Source: fixed truncated precision if the value of the millisecond or second is 0 * check CI with 1.15.3 testcontainer * check CI with 1.15.3 testcontainer * returned latest version of testcontainer * fixed checkstyle * fixed checkstyle * returned latest testcontainer version * updated CHANGELOG * bump version * auto-bump connector version * Postgres source strict encrypt bump version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
* Update StateDB to support per Stream states. * Add `StateType` type * Add `steam_name`, `namespace` and `type` to `state` table. * Set the default StateType to LEGACY
* Update getting-started-with-airbyte-cloud.md Edited Getting Started with Airbyte Cloud guide to match the updated Cloud UI. * Update getting-started-with-airbyte-cloud.md Updated based on Amruta's suggestions.
…q#13749) * airbytehq#253 oncall source fb marketing: fix issue * airbytehq#253 oncall: upd changelog * Update docs/integrations/sources/facebook-marketing.md * auto-bump connector version Co-authored-by: Evan Tahler <evan@airbyte.io> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
* Ignore Custom connectors during connectors update * Skip any connector flagged as custom as well * Format
…q#13668) * list slicer * Add comment * test * ast eval * refactor * fix * remove print * rename * return a generator * smaller fix and reset to master * union type hint * assert * comment * format
* Remove the old scheduler from HelmCharts helper The old scheduler was removed as part of airbytehq#13400 * Remove legacy `scheduler` comment in HelmCharts
* GitLab Source: add GroupIssueBoards stream * Address stream schema comments * Address comments * Bump version * Add as empty stream
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
…emental (airbytehq#14214) * increased the limit of itens in request * Configuration for max api pages on requests * included api_pagination_limit in sample * included api_pagination_limit in invalid_config * creating new table for chat_session * reverted api_pagination_limit approach * removed api_pagination_limit from TimeIncrementalStream * correct chat json * bump connector version * add changelog * run format * auto-bump connector version Co-authored-by: Roberto Bonnet <robertojuarezwp@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
…bytehq#14205) * Change the persistence activity to use the new persistence layer * Use lombok * format * Use new State message helper
* Fix build * Fix test
* Inject StatePersistence into DefaultJobCreator * Read the state from StatePersistence instead of ConfigRepository * Add a conversion helper to convert StateWrapper to State * Remove unused ConfigRepository.getConnectionState
* remove reset flags from workflow state + refactor * bring back cancelledForReset, since we need to distinguish between that case and a normal cancel * delete reset job streams on cancel or success * extract isResetJob to method * merge with master * set sync modes on streams in reset job correctly * format * Add test for getAllStreamsForConnection * fix tests * update more tests * add StreamResetActivityTests * fix tests for default job creator * remove outdated comment * remove debug lines * remove unused enum value * fix tests * fix constant equals ordering * make job mock not static * DRY and add comments * add comment about deleted streams * Remove io.airbyte.config.StreamDescriptor * regisster stream reset activity impl * refetch connection workflow when checking job id, since it may have been restarted * only cancel if workflow is running, to allow reset signal to always succeed even if batched with a workflow start * fix reset signal to use new doneWaiting workflow state prop * try to fix tests * fix reset cancel case * add acceptance test for resetting while sync is running * format * fix new acceptance test * lower sleep on test * raise sleep * increase sleep and timeout, and remove repeated test * use CatalogHelpers to extract stream descriptors * raise sleep and timeout to prevent transient failures * format Co-authored-by: alovew <anne@airbyte.io>
joshzana
approved these changes
Jun 29, 2022
| response_json = response.json() | ||
| if response_json.get('success') == False: | ||
| errors = response_json.get(self.error_field, []) | ||
| for error in errors: |
There was a problem hiding this comment.
Might want to log something if success=false but errors is empty. (or maybe they guarantee that won't happen?)
There was a problem hiding this comment.
Yup, added an extra log line to indicate that (plus the error count, because, why not)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it a lot more obvious what the actual errors are.