Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple test fails #66

Closed
wants to merge 2 commits into from
Closed

Conversation

richelbilderbeek
Copy link
Contributor

Both sfml-tmxloader and STP do not work anymore on a standard Tiled map. I suspect something upstream changed, but I have no clue.

To help you find the problem, I have created a test case. It loads a standard tiled map and checks that the number of layers is non-zero. It fails on that assert.

The test can be run with:

cd tests
./test.sh

I am willing to volunteer to find this bug, but I do need a little push in the back. OTOH, it may be trivially easy for you to find.

I also submitted the same test to STP, that suffers the same problem, as a Pull Request, so I assume if one fixes the bug, it will be easier for the other to follow.

@fallahn
Copy link
Owner

fallahn commented May 7, 2016

Thanks for the heads up, I had not yet come across this. Unfortunately I do not have the time right now to work on it right away, so if you want to volunteer yourself it would be highly appreciated (not just by me but by everyone who uses this lib)!

@fallahn
Copy link
Owner

fallahn commented May 7, 2016

I would say, however, that rather than merge these tests with the master branch that perhaps it would be wiser to work on a new branch specifically until the problem is found.

@richelbilderbeek
Copy link
Contributor Author

Thanks for the friendly response. I will post an Issue and let people fork my repo. Then this PR will update with good code. Sounds like a plan?

@fallahn
Copy link
Owner

fallahn commented May 7, 2016

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants