Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory cleanup #630

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

memory cleanup #630

wants to merge 17 commits into from

Commits on May 23, 2020

  1. fix bad negative shift

    @sandsmark
    sandsmark committed May 23, 2020
    Configuration menu
    Copy the full SHA
    7f52bea View commit details
    Browse the repository at this point in the history

  2. fix a use-after-free (should change this to a shared_ptr)

    @sandsmark
    sandsmark committed May 23, 2020
    Configuration menu
    Copy the full SHA
    c9f9b57 View commit details
    Browse the repository at this point in the history

  3. WIP: don't use bare pointers

    @sandsmark
    sandsmark committed May 23, 2020
    Configuration menu
    Copy the full SHA
    917cc81 View commit details
    Browse the repository at this point in the history

  4. make the singletons threadsafe

    @sandsmark
    sandsmark committed May 23, 2020
    Configuration menu
    Copy the full SHA
    573055c View commit details
    Browse the repository at this point in the history

  5. now that we actually delete stuff on exit, fix some broken shutdown o… 

    …rder logic
    @sandsmark
    sandsmark committed May 23, 2020
    Configuration menu
    Copy the full SHA
    bd2d868 View commit details
    Browse the repository at this point in the history

  6. fix some leaks and kinda undefined behavior

    @sandsmark
    sandsmark committed May 23, 2020
    Configuration menu
    Copy the full SHA
    777d3a2 View commit details
    Browse the repository at this point in the history

  7. fix new game screen when running with address sanitizer

    @sandsmark
    sandsmark committed May 23, 2020
    Configuration menu
    Copy the full SHA
    1ff74c3 View commit details
    Browse the repository at this point in the history

  8. refcounting ain't free, so use some const refs

    @sandsmark
    sandsmark committed May 23, 2020
    Configuration menu
    Copy the full SHA
    e3f3058 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2020

  1. WIP: gamestate needs to be unique everywhere

    @sandsmark
    sandsmark committed May 24, 2020
    Configuration menu
    Copy the full SHA
    83cad71 View commit details
    Browse the repository at this point in the history

  2. inadvertently added the sanitizer compiler flags, might as well make … 

    …it a permanent option
    @sandsmark
    sandsmark committed May 24, 2020
    Configuration menu
    Copy the full SHA
    e6a7fe9 View commit details
    Browse the repository at this point in the history

  3. enforce that State objects are owned by Game instance using unique_ptr

    @sandsmark
    sandsmark committed May 24, 2020
    Configuration menu
    Copy the full SHA
    0690089 View commit details
    Browse the repository at this point in the history

  4. try to clean up circular dependencies

    @sandsmark
    sandsmark committed May 24, 2020
    Configuration menu
    Copy the full SHA
    b21e5da View commit details
    Browse the repository at this point in the history

  5. auto is really fucking dumb, fix inadvertant circular references le… 

    …ading to memory "leaks"

50 USD to the first person who writes me a tool to automatically replace
auto with proper types in a codebase.
    @sandsmark
    sandsmark committed May 24, 2020
    Configuration menu
    Copy the full SHA
    0cda1f6 View commit details
    Browse the repository at this point in the history

  6. fix broken capturing into lambda (which are also abominations and sho… 

    …uld never have been added to c++)
    @sandsmark
    sandsmark committed May 24, 2020
    Configuration menu
    Copy the full SHA
    d0f21ba View commit details
    Browse the repository at this point in the history

  7. TODO: make the states unique pointers, since they are not supposed to… 

    … be shared resources
    @sandsmark
    sandsmark committed May 24, 2020
    Configuration menu
    Copy the full SHA
    f52a63b View commit details
    Browse the repository at this point in the history

  8. bring back some performance

    @sandsmark
    sandsmark committed May 24, 2020
    Configuration menu
    Copy the full SHA
    487375f View commit details
    Browse the repository at this point in the history

  9. cleanup

    @sandsmark
    sandsmark committed May 24, 2020
    Configuration menu
    Copy the full SHA
    5a14a3e View commit details
    Browse the repository at this point in the history