feat: refine sync method interface

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.25.0
+
+- Refine sync method interface.
+
 ## 0.24.1
 
 - Fix incorrect event emitting with NaN checks.

index.d.ts

@@ -8,7 +8,7 @@ export class StoreChannel<K extends string, V extends StoreChannelObject<K>> {
     readonly save: Observer<never[] | [K] | [K, Extract<keyof DiffStruct<V, StoreChannelObject<K>> | '', string>] | [K, Extract<keyof DiffStruct<V, StoreChannelObject<K>> | '', string>, StoreChannelEventType], StoreChannelEvent<K, V>, void>;
     readonly loss: Observer<never[] | [K] | [K, Extract<keyof DiffStruct<V, StoreChannelObject<K>> | '', string>] | [K, Extract<keyof DiffStruct<V, StoreChannelObject<K>> | '', string>, StoreChannelEventType], StoreChannelEvent<K, V>, void>;
   };
-  sync(keys: K[], cb?: (results: [K, DOMException | DOMError | Error | null][]) => void): void;
+  sync(keys: K[], cb?: (results: Promise<K>[]) => void): void;
   link(key: K, age?: number): V;
   delete(key: K): void;
   recent(limit: number, cb: (keys: K[], err?: DOMException | DOMError | Error | null) => void): void;

src/layer/domain/indexeddb/model/channel.ts

@@ -145,15 +145,23 @@ export class ChannelStore<K extends string, V extends StoreChannelObject<K>> {
     save: new Observation<never[] | [K] | [K, Extract<keyof DiffStruct<V, StoreChannelObject<K>> | '', string>] | [K, Extract<keyof DiffStruct<V, StoreChannelObject<K>> | '', string>, ChannelStore.EventType], ChannelStore.Event<K, V>, void>({ limit: Infinity }),
     loss: new Observation<never[] | [K] | [K, Extract<keyof DiffStruct<V, StoreChannelObject<K>> | '', string>] | [K, Extract<keyof DiffStruct<V, StoreChannelObject<K>> | '', string>, ChannelStore.EventType], ChannelStore.Event<K, V>, void>({ limit: Infinity }),
   });
-  public sync(keys: K[], cb: (results: [K, DOMException | DOMError | null][]) => void = noop, timeout = Infinity): void {
+  public sync(keys: K[], cb: (results: Promise<K>[]) => void = noop, timeout = Infinity): void {
     const cancellation = new Cancellation();
     if (Number.isFinite(timeout)) {
       void setTimeout(cancellation.cancel, timeout);
     }
     return void Promise.all(keys.map(key =>
-      new Promise(resolve =>
-        void this.fetch(key, error =>
-          void resolve([key, error]), cancellation))))
+      new Promise<[K, Error | DOMError | null]>(resolve =>
+        void this.fetch(
+          key,
+          error =>
+            void resolve([key, error]),
+          cancellation))))
+      .then(rs =>
+        rs.map(([key, error]) =>
+          error
+            ? Promise.reject(error)
+            : Promise.resolve(key)))
       .then(cb);
   }
   public fetch(key: K, cb: (error: DOMException | DOMError | Error | null) => void = noop, cancellation = new Cancellation()): void {

src/layer/domain/indexeddb/service/channel.test.ts

@@ -58,8 +58,8 @@ describe('Unit: layers/domain/indexeddb/service/channel', function () {
       listen_('test', db => {
         db.transaction('data', 'readwrite').objectStore('data').put(adjust(new StoreChannel.Record('a', { n: 1 })));
         db.transaction('data', 'readwrite').objectStore('data').put(adjust(new StoreChannel.Record('a', { s: '1' }))).onsuccess = () => {
-          chan.sync(['a', 'z'], results => {
-            assert.deepStrictEqual(results, [['a', null], ['z', null]]);
+          chan.sync(['a', 'z'], async results => {
+            assert.deepStrictEqual(await Promise.all(results), ['a', 'z']);
             const link = chan.link('a');
             assert(link.__id === 2);
             assert(link.__key === 'a');