Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project-refactors #3

Closed
wants to merge 11 commits into from
Closed

Conversation

nopeless
Copy link

ESM build is now working. Now people can do npm i spica to use your project

@nopeless
Copy link
Author

@falsandtru

@falsandtru
Copy link
Owner

I said the important thing is to unify the build method with webpack. But you seem to have removed webpack. Why webpack is required is written in webpack/webpack#5866.

@nopeless
Copy link
Author

I said the important thing is to unify the build method with webpack. But you seem to have removed webpack. Why webpack is required is written in webpack/webpack#5866.

@falsandtru The only reason why this project should support a bundled js files is if people are importing your project via <script>. I honestly don't see that happening. For every other users who are using a bundler, this type of build should be just fine

Here is why I think webpack and tsc is both needed

  • tsc is needed to build typescript files and emit them to dist, primarily for node users to import their projects. For those who are web developers, they can use a bundler on their and the code should still work.
  • webpack is needed to run Karma tests
    @falsandtru

@falsandtru
Copy link
Owner

The only reason why this project should support a bundled js files

No. This project must NOT distribute bundled files because bundled files of modules contain duplicate code. Additionally, your distribution files would contain assertions that must be removed.

@nopeless
Copy link
Author

The only reason why this project should support a bundled js files

No. This project must NOT distribute bundled files because bundled files of modules contain duplicate code. Additionally, your distribution files would contain assertions that must be removed.

We are on the same page. I am saying that the project shouldn't distribute bundled files.

I'll look into removing assertions though, didn't think about that

@nopeless
Copy link
Author

@falsandtru asserts are removed, but I don't know if declarationMap will work fine. Can you try it out?

@falsandtru
Copy link
Owner

You don't understand why people need webpack/webpack#5866.

@falsandtru falsandtru closed this Jun 16, 2023
@nopeless
Copy link
Author

can YOU just fix the code so people don't have to set up a bundler/compiler just to run this project then

@nopeless
Copy link
Author

this pr literally doesn't change anything other than letting node users use the project like any other project and you can't understand that either

@falsandtru
Copy link
Owner

This currently supports only TS because of webpack/webpack#5866. Over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants