-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project-refactors #3
Conversation
I said the important thing is to unify the build method with webpack. But you seem to have removed webpack. Why webpack is required is written in webpack/webpack#5866. |
@falsandtru The only reason why this project should support a bundled js files is if people are importing your project via Here is why I think webpack and
|
No. This project must NOT distribute bundled files because bundled files of modules contain duplicate code. Additionally, your distribution files would contain assertions that must be removed. |
We are on the same page. I am saying that the project shouldn't distribute bundled files. I'll look into removing assertions though, didn't think about that |
@falsandtru asserts are removed, but I don't know if |
You don't understand why people need webpack/webpack#5866. |
can YOU just fix the code so people don't have to set up a bundler/compiler just to run this project then |
this pr literally doesn't change anything other than letting node users use the project like any other project and you can't understand that either |
This currently supports only TS because of webpack/webpack#5866. Over. |
ESM build is now working. Now people can do
npm i spica
to use your project