Skip to content

Commit

Permalink
Remove obsolete evaluation types (#102)
Browse files Browse the repository at this point in the history
Remove `Scope`, `Scoring`, and `Statement` properties from `Evaluation` type alongside their backing types.
  • Loading branch information
mburumaxwell committed Jul 20, 2022
1 parent 6bc3d92 commit da37701
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 83 deletions.
19 changes: 0 additions & 19 deletions src/FaluSdk/Evaluations/Evaluation.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ public class Evaluation : EvaluationPatchModel, IHasId, IHasCurrency, IHasCreate
/// <inheritdoc/>
public string? Currency { get; set; }

/// <summary>
/// Scope of the evaluation.
/// </summary>
[Obsolete("Moved to Options")]
public string? Scope { get; set; }

/// <inheritdoc/>
public DateTimeOffset Created { get; set; }

Expand All @@ -33,12 +27,6 @@ public class Evaluation : EvaluationPatchModel, IHasId, IHasCurrency, IHasCreate
/// </summary>
public EvaluationScoringOptions? Options { get; set; }

/// <summary>
/// Statement used for the evaluation.
/// </summary>
[Obsolete("Moved to Reports or Outputs")]
public Statement? Statement { get; set; }

/// <summary>
/// The short-lived client secret used by front-end libraries to show an evaluation modal inside your app.
/// This client secret expires after 24 hours and can only be used once.
Expand All @@ -54,13 +42,6 @@ public class Evaluation : EvaluationPatchModel, IHasId, IHasCurrency, IHasCreate
/// </summary>
public string? Url { get; set; }

/// <summary>
/// Scoring generated for the evaluation.
/// Only populated if extraction succeeded.
/// </summary>
[Obsolete("Moved to Outputs")]
public EvaluationScoring? Scoring { get; set; }

/// <summary>
/// Unique identifiers of the reports for this verification.
/// </summary>
Expand Down
24 changes: 0 additions & 24 deletions src/FaluSdk/Evaluations/EvaluationScoring.cs

This file was deleted.

40 changes: 0 additions & 40 deletions src/FaluSdk/Evaluations/Statement.cs

This file was deleted.

0 comments on commit da37701

Please sign in to comment.