Make seshat compile on default options in Ubuntu 18.04 (c++11) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2018 20:19
disambiguate boost::tuple and std::tuple.
This was referenced Oct 10, 2018
khoivn
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disambiguate boost::tuple and std::tuple.
On 18.04 default libboost version is 1.65 and g++ is using c++11 and libxerces is 3.2.
This version of libxerces requires c++11 rendering the flag c++98 option useless (if you don't want to recompile).
In this patchset I just added references to force Helper.hpp to use the boost version of tuple (without them, it uses the new std::tuple or gets ambiguous calls).
I also added -fpermissive otherwise the build fails on perturb_weights function.