Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus 5X isn't compatible? #1

Closed
Hund opened this issue May 17, 2016 · 17 comments
Closed

Nexus 5X isn't compatible? #1

Hund opened this issue May 17, 2016 · 17 comments

Comments

@Hund
Copy link

Hund commented May 17, 2016

According to F-droid this launcher isn't compatible with Nexus 5X. But I tried installing it anyway and it just crashes if I try to use it.

How come the Nexus 5X isn't supported? :)

@Hund Hund changed the title Compatible devices? Nexus 5X isn't compatible? May 17, 2016
@fandreuz
Copy link
Owner

It's compatible, F-Droid Repository isn't updated. You can be sure only with Play Store

@Hund
Copy link
Author

Hund commented May 17, 2016

Ah! Then I'll wait. :) I dont have Play Store or any Google service on my phone.

@ghost
Copy link

ghost commented May 18, 2016

It's listed as not compatible, because it requires commons-io as a native lib -- so all devices are listed as incompatible Most likely due it being in libs instead of app/libs.

@Hund
Copy link
Author

Hund commented May 18, 2016

I see. But, I'm not sure I totally understand though. Why didn't you include the lib if it's a required dependency?

On 18 May 2016 02:15:22 CEST, Boris Kraut notifications@github.com wrote:

It's listed as not compatible, because it requires commons-io as a
native lib -- so all devices are listed as incompatible Most likely due
it being in libs instead of app/libs.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#1 (comment)

@fandreuz
Copy link
Owner

I don't own the fdroid repo. It's not me. Someone can send me a link to the repository?

@Hund
Copy link
Author

Hund commented May 18, 2016

@ghost
Copy link

ghost commented May 18, 2016

While I dont "own" the repo, I added the build. It will be removed today, until I got it building and working fine.

@Hund: We strip binary files and replace them. Either we build them from source (like we did with CompareString) or we pull them from a trusted repostiory (in the case for commons-io mavenCentral). However, the build crashes on my CM13 device even with no modification applied. I will need some time to look into it and provide a logcat later.

@fandreuz
Copy link
Owner

@krt16s sorry for my ignorance about f-droid, but I didn't understand. What did you do?

@licaon-kter
Copy link
Contributor

@krt16s confirmed crash see #4

Not sure how to get https://github.com/Andre1299/CompareString pulled at build time though, tried https://jitpack.io but no joy.

@licaon-kter licaon-kter mentioned this issue May 18, 2016
fandreuz pushed a commit that referenced this issue May 18, 2016
fandreuz pushed a commit that referenced this issue May 18, 2016
@fandreuz fandreuz reopened this May 19, 2016
@ghost
Copy link

ghost commented May 21, 2016

Sorry for being unavailable for some days..exams are going on :) I will have a closer look at your changes tonight, retry the build locally and if it still fails, get you some logcats.

@ghost
Copy link

ghost commented May 25, 2016

For me the build works now. Tested this on Android4, 5 and 6. On Android6 the app crashes because it does not ask for permissions (prior those were granted on installation, on Android6 permissions have to be requested at runtime): I have to workaround that by allowing permissions manually.

Edit: Also tested on an actual device running CM13/Android6.

@fandreuz
Copy link
Owner

The app shouldn't crash, it opens the Settings page where you can grant the permissions. Can you send me a log?

@ghost
Copy link

ghost commented May 25, 2016

Oh, it does open the app info page, indeed, but still displays a message of being shut down. No indication that I should grant permission. So most likely it's "fixed" but the fix/workaround itself is not self-explanatory :) Anyway, attached the logfile from an Android6 emulator.

consolelauncher.txt

@fandreuz
Copy link
Owner

@krt16s The latest commit doesn't crash. But I updated it two days ago. You can find the build here: https://drive.google.com/open?id=0B-3mPrdQkEHQQUFNNFllQU5ybW8

@ghost
Copy link

ghost commented May 25, 2016

I used ae55d1a for the testing. This is the latest commit I see in this repo.

@licaon-kter
Copy link
Contributor

I just compiled it, on first start it switched to the app info asking for permissions, that I granted, but it worked fine after that (on 6.0.1).

@ghost
Copy link

ghost commented May 25, 2016

The difference from the latest commit here and the file posted is the message that popsup when no permission have been granted. ae55d1a looks like a crash, the apk posted above informs the user to change permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants