-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nexus 5X isn't compatible? #1
Comments
It's compatible, F-Droid Repository isn't updated. You can be sure only with Play Store |
Ah! Then I'll wait. :) I dont have Play Store or any Google service on my phone. |
It's listed as not compatible, because it requires commons-io as a native lib -- so all devices are listed as incompatible Most likely due it being in libs instead of app/libs. |
I see. But, I'm not sure I totally understand though. Why didn't you include the lib if it's a required dependency? On 18 May 2016 02:15:22 CEST, Boris Kraut notifications@github.com wrote:
|
I don't own the fdroid repo. It's not me. Someone can send me a link to the repository? |
While I dont "own" the repo, I added the build. It will be removed today, until I got it building and working fine. @Hund: We strip binary files and replace them. Either we build them from source (like we did with CompareString) or we pull them from a trusted repostiory (in the case for commons-io mavenCentral). However, the build crashes on my CM13 device even with no modification applied. I will need some time to look into it and provide a logcat later. |
@krt16s sorry for my ignorance about f-droid, but I didn't understand. What did you do? |
@krt16s confirmed crash see #4 Not sure how to get https://github.com/Andre1299/CompareString pulled at build time though, tried https://jitpack.io but no joy. |
Sorry for being unavailable for some days..exams are going on :) I will have a closer look at your changes tonight, retry the build locally and if it still fails, get you some logcats. |
For me the build works now. Tested this on Android4, 5 and 6. On Android6 the app crashes because it does not ask for permissions (prior those were granted on installation, on Android6 permissions have to be requested at runtime): I have to workaround that by allowing permissions manually. Edit: Also tested on an actual device running CM13/Android6. |
The app shouldn't crash, it opens the Settings page where you can grant the permissions. Can you send me a log? |
Oh, it does open the app info page, indeed, but still displays a message of being shut down. No indication that I should grant permission. So most likely it's "fixed" but the fix/workaround itself is not self-explanatory :) Anyway, attached the logfile from an Android6 emulator. |
@krt16s The latest commit doesn't crash. But I updated it two days ago. You can find the build here: https://drive.google.com/open?id=0B-3mPrdQkEHQQUFNNFllQU5ybW8 |
I used ae55d1a for the testing. This is the latest commit I see in this repo. |
I just compiled it, on first start it switched to the app info asking for permissions, that I granted, but it worked fine after that (on 6.0.1). |
The difference from the latest commit here and the file posted is the message that popsup when no permission have been granted. ae55d1a looks like a crash, the apk posted above informs the user to change permission. |
According to F-droid this launcher isn't compatible with Nexus 5X. But I tried installing it anyway and it just crashes if I try to use it.
How come the Nexus 5X isn't supported? :)
The text was updated successfully, but these errors were encountered: