Improve python processing using asyncio #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! :) Feel free to contribute more! |
|
I will.. I would like to find a way to start both the node application and the python fake cam app from the same script, but it is not working fine so far. I guess we could just add a bash script, but meh.. |
|
Or you could use the Docker version and type in |
|
Ah, fair enough! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
first of all, thanks for this amazing PoC! I have improved the Python processing with asyncio and adding an object which will be more maintainable.
The new version uses a little bit less CPU and it is more fluid in my tests. I have also added an argument parser with defaults to allow people to easily tune parameters.