forked from kerryjiang/SuperSocket.ClientEngine
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix crash at System.Net.Sockets.Socket.ResetHandle()
- Loading branch information
Fanglin Liu
committed
Mar 16, 2015
1 parent
70a02fb
commit e461226
Showing
1 changed file
with
53 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e461226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your fix! But you should do more adjustment work to align with my original design.
It will be helpful to avoid introducing more other issues.
For example you change doesn't support IPv6 very well because you define the socket instance address family as AddressFamily.InterNetwork (IPv4 only) explicity.
Client = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
There must be other small isssues beside this one. But anyway, it is a great progress. Come on please, I am exiting to see somebody else can join me to develop good open source projects.
e461226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you pointing out the issues. I am new C# developer for 2 months. I am iOS developer. There must be some other issues. Thanks again for pointing out this issue. I will improve that.
e461226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there guys, any news on how should be the final code here?
So far, I've tested on WP, iOS and Droid and no error.
But my mobile app does not use ipv6 anyway, so looks like I'm safe.
e461226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fanglinliu Do you have any update? Probably I need pay some time to understand how this change fix the issue.