Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize testing #112

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Modularize testing #112

wants to merge 5 commits into from

Conversation

iamashwin99
Copy link
Collaborator

  • Move the sourcing of spack, creating env, running the spec, installing the spec and testing it into a separate bash script
  • allows using the spack_test_install.sh multiple times for different specs ( for eg cmake, different compilers etc ) with less code duplication in the future
  • allows using the spack_test_install.sh outside the repo for manual testing
  • allows creation of a CI that tests the installation of the spack upstream package definition as well ( checks for eg when the download links fail or for changes in spack)

@iamashwin99
Copy link
Collaborator Author

iamashwin99 commented Jun 7, 2024

The failed build in spack-develop-octopus-develop is due to a problem in octopus main branch and is independent of this MR. see for eg a CI run on current the develop https://github.com/fangohr/octopus-in-spack/actions/runs/9406513594/job/25910128602 which also fails.

Reported at https://gitlab.com/octopus-code/octopus/-/issues/1029

@iamashwin99
Copy link
Collaborator Author

@fangohr, given that the test failures are due to some changes in octopus develop, which have already been reported upstream, what should our strategy be for this and following MRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant