Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos found by codespell #94

Merged
merged 1 commit into from Sep 8, 2023
Merged

Fix typos found by codespell #94

merged 1 commit into from Sep 8, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

I guess the compatiblity typo is from Mathworks and should not be fixed here:

jsonlab/jsonlab.prj

Lines 44 to 47 in 7d7e7f7

<param.compatiblity.windows>true</param.compatiblity.windows>
<param.compatiblity.macos>true</param.compatiblity.macos>
<param.compatiblity.linux>true</param.compatiblity.linux>
<param.compatiblity.matlabonline>true</param.compatiblity.matlabonline>

@fangq fangq merged commit 0900704 into fangq:master Sep 8, 2023
7 checks passed
@fangq
Copy link
Owner

fangq commented Sep 8, 2023

thanks, merged. I agree that the .prj key name should not be fixed.

@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch September 8, 2023 15:37
@DimitriPapadopoulos
Copy link
Contributor Author

Thanks. Out of curiosity, I couldn't find any online documentation on Matlab project files. Do you know of any?

@fangq
Copy link
Owner

fangq commented Sep 8, 2023

Thanks. Out of curiosity, I couldn't find any online documentation on Matlab project files. Do you know of any?

I don't believe I have ever released the toolbox using .mltbx formatted package, although you could build this package using the .prj file, jsonlab is portable enough that it could just be deployed with a zip/tarball.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants