Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate redundant forcing grids #168

Closed
fankiat opened this issue Jan 5, 2023 · 0 comments · Fixed by #169
Closed

Deprecate redundant forcing grids #168

fankiat opened this issue Jan 5, 2023 · 0 comments · Fixed by #169
Assignees
@fankiat
Labels
prio:high High priority refactor Refactor existing codebase

Comments

@fankiat
Copy link
Owner

fankiat commented Jan 5, 2023

As mentioned in #163 , the forcing grids in sopht-mpi are for the most part the same as the ones in sopht-simulator. We could get rid of this redundancy, since forcing grid is not a collective notion in the MPI context (it resides only one master_rank).
@fankiat fankiat added refactor Refactor existing codebase prio:high High priority labels Jan 5, 2023
@fankiat fankiat self-assigned this Jan 5, 2023
This was referenced Jan 5, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fankiat fankiat

Labels
prio:high High priority refactor Refactor existing codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate forcing grids and flow forces fankiat/sopht-mpi
1 participant
@fankiat