Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test-suite validating Id is spec conformant #61

Closed
wants to merge 3 commits into from

Conversation

phadej
Copy link
Contributor

@phadej phadej commented Apr 13, 2014

Test suite code could be generalised to be ~ applicable as is to any implementation.

@SimonRichardson
Copy link
Member

Just a quick observation, can you use fantasy-combinators as a minimum for identity and the like.

I'll do a better review when I get time.

@phadej
Copy link
Contributor Author

phadej commented Apr 13, 2014

@SimonRichardson, I could, but I'd like fantasy-combinators to be autocurried...

@SimonRichardson
Copy link
Member

Add an issue to the repo, we can discuss :-)

@phadej
Copy link
Contributor Author

phadej commented Apr 13, 2014

@SimonRichardson, you have already a PR made about, it's just not merged yet.

@SimonRichardson
Copy link
Member

Haha, you know it's bad when you don't remember that you've already made a pull request for it.

@SimonRichardson
Copy link
Member

@phadej just waiting to hear back.

@SimonRichardson
Copy link
Member

@phadej we should use fantasy-check to verify Id. It will fall in line with other packages in fantasy-land.

@phadej
Copy link
Contributor Author

phadej commented Apr 15, 2014

Didn't noticed fantasy-check, as it's not under fantasyland group. Looks like you have your own quickcheck clone built-in there. That would be perfect fit for jsverify too :( Feel free to close this.

@SimonRichardson
Copy link
Member

@phadej yeah I need to move it in tbh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants