Add lang props with lang APIXU lang codes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Translate to ES Wind Speed and Humidity Add icon 1189 to utils.icons
|
@es11400 thanks for your pull request, can you please fix the failed tests so i can merge this request? |
|
Hi, I have corrected the errors and the tests are already running. |
…he texts, these are called from utils.js
Test to return night icons
|
Thanks @es11400 i will work on your feedbacks and @andreasviklund on a separate branch will try to cover more icons cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Translate to ES Wind Speed and Humidity
Add icon 1189 to utils.icons