Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "this" as a globalObject in webpack #56

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Use "this" as a globalObject in webpack #56

merged 1 commit into from
Apr 17, 2021

Conversation

fgagneten-cm
Copy link

Fix issue: #50

Use "this" instead of "self" as a global object to avoid referenceError

@fgagneten-cm fgagneten-cm mentioned this pull request Apr 17, 2021
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.116% when pulling 322e3ee on fgagneten-cm:fix/self_undefined into 468cb43 on farahat80:master.

@farahat80 farahat80 merged commit f6fa5d9 into farahat80:master Apr 17, 2021
@farahat80
Copy link
Owner

@fgagneten-cm thanks for fixing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fgagneten-cm @coveralls @farahat80 @fgagneten