Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] Seed for generate_random_map() in FrozenLake? #127

Closed
1 task done
kir0ul opened this issue Nov 13, 2022 · 1 comment · Fixed by #139
Closed
1 task done

[Proposal] Seed for generate_random_map() in FrozenLake? #127

kir0ul opened this issue Nov 13, 2022 · 1 comment · Fixed by #139
Labels
enhancement New feature or request

Comments

@kir0ul
Copy link
Contributor

kir0ul commented Nov 13, 2022

Proposal

Could be useful to be able to pass a seed to the generate_random_map() function in FrozenLake.

Motivation

Being able to get reproducible generated maps.

Pitch

Being able to call generate_random_map(size=8, seed=123).

Alternatives

No response

Additional context

No response

Checklist

  • I have checked that there is no similar issue in the repo
@kir0ul kir0ul added the enhancement New feature or request label Nov 13, 2022
@kir0ul kir0ul changed the title [Proposal] Seed for generate_random_map in FrozenLake? [Proposal] Seed for generate_random_map() in FrozenLake? Nov 13, 2022
@pseudo-rnd-thoughts
Copy link
Member

This seems like a critical issue, could you make a PR that solves this.
Not sure, if we want the __init__ to contain a map_seed parameter or for the map data to be set in reset and use the seed value

@kir0ul kir0ul mentioned this issue Nov 17, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FrozenLake] Add seed in random map generation kir0ul/Gymnasium
2 participants
@kir0ul @pseudo-rnd-thoughts