Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync): Implement a simple Engine sync over RPC #106

Merged
merged 3 commits into from
Sep 13, 2022

Conversation

sagar-a16z
Copy link
Contributor

@sagar-a16z sagar-a16z commented Sep 13, 2022

Motivation

Fixes #102

Change Summary

  • Wrote a simple test that copies data from one Engine (server) to another (client) over RPC.
  • Added RPC APIs for querying IDRegistry events as well

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

  • The title of this PR adheres to the conventional commits standard
  • The PR has been tagged with the appropriate change type label(s) (i.e. documentation, feature, bugfix, or chore)

Additional Context

Depends on #105.
I will rebase this once that's landed.

@sagar-a16z sagar-a16z added the t-feat Add a new feature or protocol improvement label Sep 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2022

Codecov Report

Base: 90.51% // Head: 90.68% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (53c1672) compared to base (e765257).
Patch coverage: 92.30% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   90.51%   90.68%   +0.16%     
==========================================
  Files          23       23              
  Lines        1329     1342      +13     
  Branches      268      271       +3     
==========================================
+ Hits         1203     1217      +14     
+ Misses        119      118       -1     
  Partials        7        7              
Impacted Files Coverage Δ
src/network/rpc.ts 90.62% <90.00%> (-0.08%) ⬇️
src/engine/index.ts 85.85% <100.00%> (+0.13%) ⬆️
src/sets/signerSet.ts 97.41% <0.00%> (+1.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/network/rpc.ts Outdated Show resolved Hide resolved
src/engine/index.ts Outdated Show resolved Hide resolved
src/network/rpc.sync.test.ts Outdated Show resolved Hide resolved
src/network/rpc.sync.test.ts Outdated Show resolved Hide resolved
src/network/rpc.sync.test.ts Outdated Show resolved Hide resolved
src/network/rpc.sync.test.ts Outdated Show resolved Hide resolved
src/network/rpc.sync.test.ts Outdated Show resolved Hide resolved
@varunsrin varunsrin merged commit ccd4cdb into farcasterxyz:main Sep 13, 2022
@sagar-a16z sagar-a16z deleted the engine_sync_1 branch September 13, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-feat Add a new feature or protocol improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(sync): Implement a simple Engine sync over RPC
4 participants