Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add stats for bundle message delays, stale contact info #2118

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

Wazzymandias
Copy link
Contributor

@Wazzymandias Wazzymandias commented Jul 2, 2024

Motivation

  • Need better visibility into message delays and disambiguate between bundle delay and message delay
  • Ensure stale contacts aren't disseminating through the network

Change Summary

  • Add statsd metrics for earliest and latest message timestamp in bundle and bundle creation timestamp. All timestamps are in farcaster time
  • Add statsd metric for old contact info being gossiped

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR focuses on enhancing message bundle submission in the Hubble application by adding stats for message delays and contact info staleness.

Detailed summary

  • Added stats for bundle message delays and stale contact info
  • Updated submitMessageBundle method parameters in multiple files
  • Updated submitMessageBundle method in Hub class to include additional stats and parameters

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@Wazzymandias Wazzymandias added the t-chore Miscellaneous improvements label Jul 2, 2024
Copy link

changeset-bot bot commented Jul 2, 2024

🦋 Changeset detected

Latest commit: 2e5270b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 11:53pm

@Wazzymandias Wazzymandias merged commit fdcc3b5 into main Jul 3, 2024
8 checks passed
@Wazzymandias Wazzymandias deleted the chore/statsd-metrics branch July 3, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-chore Miscellaneous improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant