Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hubble): hub operator fid is not set docker compose #2129

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

aquaticone
Copy link
Contributor

@aquaticone aquaticone commented Jul 7, 2024

Motivation

Fixes #2088 #2117

There is likely an underlying issue with the commander configuration but this is a quick change that gets this working for those having trouble getting the container up and running.

Change Summary

Reordered CLI arguments in docker-compose.yml.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR updates the docker-compose.yml file for the @farcaster/hubble app to fix an issue with CLI arguments order affecting the hub operator FID.

Detailed summary

  • Added --hub-operator-fid ${HUB_OPERATOR_FID:-0} to fix unset hub operator FID in docker-compose.yml.
  • Rearranged CLI arguments to ensure correct order and parameter assignment.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Reordered CLI arguments in docker-compose.yml
Copy link

changeset-bot bot commented Jul 7, 2024

🦋 Changeset detected

Latest commit: 3bd42a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2024 0:03am

@sds sds added the t-bug A fix for a bug with the current system label Jul 8, 2024
@sds
Copy link
Member

sds commented Jul 8, 2024

Thanks! It looks like we (unintentionally) have our --hub-operator-fid flag set further down in our list of CLI flags in our production environment, which is why we haven't seen this issue ourselves.

Appreciate the workaround fix.

@sds sds enabled auto-merge (squash) July 8, 2024 23:04
@sds sds merged commit 795815a into farcasterxyz:main Jul 8, 2024
8 checks passed
@aquaticone aquaticone deleted the fix/hub-operator-fid-docker branch July 9, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Hub Operator FID is not set" via docker even already set in .env
2 participants