chore: review and fix or suppress eslint-security warnings

[varunsrin]

What is the feature you would like to implement?

Review and fix all eslint security warnings or suppress them if they are false positives.

➜  hub git:(varunsrin/eslint-security) yarn lint:fix

/Users/varun/src/farcaster/hub/src/network/sync/merkleTrie.ts
  60:18  warning  Variable Assigned to Object Injection Sink  security/detect-object-injection

/Users/varun/src/farcaster/hub/src/storage/db/rocksdb.ts
  90:11  warning  Found fs.open with non literal argument at index 0  security/detect-non-literal-fs-filename

/Users/varun/src/farcaster/hub/src/urls/chainAccountUrl.ts
  35:30  warning  Found non-literal argument to RegExp Constructor  security/detect-non-literal-regexp

/Users/varun/src/farcaster/hub/src/urls/chainUrl.ts
  28:30  warning  Found non-literal argument to RegExp Constructor  security/detect-non-literal-regexp

/Users/varun/src/farcaster/hub/src/urls/utils.ts
  14:12  warning  Generic Object Injection Sink                     security/detect-object-injection
  28:8   warning  Found non-literal argument to RegExp Constructor  security/detect-non-literal-regexp
  32:28  warning  Found non-literal argument to RegExp Constructor  security/detect-non-literal-regexp
  32:39  warning  Generic Object Injection Sink                     security/detect-object-injection

/Users/varun/src/farcaster/hub/src/utils/crypto.ts
  57:16  warning  Generic Object Injection Sink        security/detect-object-injection
  59:21  warning  Function Call Object Injection Sink  security/detect-object-injection

[avichalp]

Hey @varunsrin,

If no one has already started working on it, I would like to take a stab. I see that is it a good opportunity to familiarize myself with the codebase.

[varunsrin]

tim had a WIP PR here a few days ago: #262

i would ping him there and see if he is still working on it, if not its all yours

[avichalp]

Ah sorry! I saw that PR earlier. I thought these were a new set of warnings that had come up. I will follow that PR there.

[varunsrin]

@avichalp and @djma i'm not sure if tim is working on it anymore, so this is up for grabs

[TimDaub]

I think it should be merged asap to reduce potential merge conflicts

[TimDaub]

actually whatever, there are too many now. I will close