Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a function to decode .tsx files #1

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Conversation

chiguireitor
Copy link
Contributor

Also fixed the Object struct to accept non-integer x, y, width and heights

@fardog
Copy link
Owner

fardog commented Sep 27, 2018

this looks reasonable; thanks for the contribution! i'm unsure about the float change: i took the description from the docs:

The x coordinate of the object in pixels.

...to mean that it was an integer; do you have an example of a file generated from tiled that uses a float here? this will change the public API, but I've never considered it "locked" so that's cool if it generates tilesets this way.

@chiguireitor
Copy link
Contributor Author

Yeah, latest Tiled exposes those "Objects" as floats... guess because they could be zoomed in etc.

@fardog fardog merged commit 1e9f886 into fardog:master Sep 27, 2018
@fardog
Copy link
Owner

fardog commented Sep 27, 2018

sounds good to me. thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants