Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields: objectalignment and tile object type #5

Merged
merged 1 commit into from
Jan 23, 2021

Conversation

divVerent
Copy link
Contributor

Add support for maps with different object alignment (Tiled 1.4) and tile objects (Tiled 1.0).

XML tags: and
Go attributes: TileSet.ObjectAlignment and Tile.Type

Fixes #4

Add support for maps with different object alignment (Tiled 1.4) and tile objects (Tiled 1.0).

XML tags: <tileset objectalignment="..."> and <tile type="...">
Go attributes: TileSet.ObjectAlignment and Tile.Type

Fixes fardog#4
divVerent added a commit to divVerent/aaaaxy that referenced this pull request Jan 19, 2021
divVerent added a commit to divVerent/aaaaxy that referenced this pull request Jan 21, 2021
@fardog
Copy link
Owner

fardog commented Jan 23, 2021

looks reasonable to me. thanks for the contribution!

@fardog fardog merged commit c6b7c35 into fardog:master Jan 23, 2021
divVerent added a commit to divVerent/tmx that referenced this pull request Jan 27, 2021
Sorry, I had a stupid mistake in fardog#5 and have no idea why I hadn't noticed while testing.

This time I cleared our my Go module cache and put the edited file there manually to test it for real.

Sorry for that.
divVerent added a commit to divVerent/tmx that referenced this pull request Jan 27, 2021
Sorry, I had a stupid mistake in fardog#5 and have no idea why I hadn't noticed while testing.

This time I cleared our my Go module cache and put the edited file there manually to test it for real.

Sorry for that.
divVerent added a commit to divVerent/tmx that referenced this pull request Jan 27, 2021
Sorry, I had a stupid mistake in fardog#5 and have
no idea why I hadn't noticed while testing.

This time I cleared out my Go module cache and put the edited file there
manually to test it for real.

Sorry for that.
divVerent added a commit to divVerent/aaaaxy that referenced this pull request Jan 27, 2021
divVerent added a commit to divVerent/aaaaxy that referenced this pull request Jan 27, 2021
fardog pushed a commit that referenced this pull request Feb 11, 2021
Sorry, I had a stupid mistake in #5 and have
no idea why I hadn't noticed while testing.

This time I cleared out my Go module cache and put the edited file there
manually to test it for real.

Sorry for that.
divVerent added a commit to divVerent/aaaaxy that referenced this pull request Feb 13, 2021
@divVerent divVerent deleted the patch-1 branch May 4, 2021 10:46
divVerent added a commit to divVerent/aaaaxy that referenced this pull request Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: add parsing for ObjectAlignment
2 participants