New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a process to look at the timestamp and reload the term if it is not latest #56
Conversation
…on :reload_customize_messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
テスト test/functional/custom_message_settings_controller_test.rb が失敗します。
% RAILS_ENV=test bundle exec rake redmine:plugins:test NAME=redmine_message_customize
Run options: --seed 40894
# Running:
.....F
Failure:
CustomMessageSettingsControllerTest#test_update_with_custom_messages_yaml [./plugins/redmine_message_customize/test/functional/custom_message_settings_controller_test.rb:65]:
Expected: "Home3"
Actual: "Home1"
rails test plugins/redmine_message_customize/test/functional/custom_message_settings_controller_test.rb:59
..F
Failure:
CustomMessageSettingsControllerTest#test_toggle_enabled [./plugins/redmine_message_customize/test/functional/custom_message_settings_controller_test.rb:86]:
Expected response to be a <3XX: redirect>, but was a <200: OK>
rails test plugins/redmine_message_customize/test/functional/custom_message_settings_controller_test.rb:84
.F
Failure:
CustomMessageSettingsControllerTest#test_default_messages [./plugins/redmine_message_customize/test/functional/custom_message_settings_controller_test.rb:37]:
<Confirm default messages(config/locales/ja.yml)> expected but was
<Confirm your password to continue>..
Expected 0 to be >= 1.
rails test plugins/redmine_message_customize/test/functional/custom_message_settings_controller_test.rb:33
.F
Failure:
CustomMessageSettingsControllerTest#test_update_with_custom_messages [./plugins/redmine_message_customize/test/functional/custom_message_settings_controller_test.rb:55]:
Expected: "Home3"
Actual: "Home1"
rails test plugins/redmine_message_customize/test/functional/custom_message_settings_controller_test.rb:49
F
Failure:
CustomMessageSettingsControllerTest#test_update_with_invalid_params [./plugins/redmine_message_customize/test/functional/custom_message_settings_controller_test.rb:73]:
<Message customize> expected but was
<Confirm your password to continue>..
Expected 0 to be >= 1.
rails test plugins/redmine_message_customize/test/functional/custom_message_settings_controller_test.rb:69
F
Failure:
CustomMessageSettingsControllerTest#test_edit [./plugins/redmine_message_customize/test/functional/custom_message_settings_controller_test.rb:20]:
<Message customize> expected but was
<Confirm your password to continue>..
Expected 0 to be >= 1.
rails test plugins/redmine_message_customize/test/functional/custom_message_settings_controller_test.rb:16
........................
Finished in 3.080297s, 12.6611 runs/s, 34.0876 assertions/s.
39 runs, 105 assertions, 6 failures, 0 errors, 0 skips
@yui-har |
f3c6219 のパッチを当てた状態でテストを実施しました。 |
という状態に合わせても再現できませんでした。 |
seed の値によって、テスト成功・失敗します。
|
@ishikawa999 |
@ishikawa999 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(テストは残っていますけど)レビュー完了です、masterブランチにマージしてください。
テストは再現ができなかった + テストが失敗した環境でも該当する機能の動作は問題無かったため、マージします |
If requests are distributed between two web servers, such as ALB, there is a problem that only one of them reloads i18n and the terms are not updated.
In order to allow reloading on the other web server as well, we check each request to see if the redmine_message_customize_timestamp is out of date and reload the i18n if it is.