Proxy protocol v1 support: Removed automatic socket destruction on er…

…rors, it was introduced by mistake. Proxy protocol tests: server reset after each test.
farhadi · Sep 28, 2021 · 2bd2152 · 2bd2152
1 parent d613937
commit 2bd2152
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/smpp.js b/lib/smpp.js
@@ -87,7 +87,6 @@ function Session(options) {
 	this.socket.on('error', function(e) {
 		clearTimeout(connectTimeout);
 		self.debug("socket.error", e.message, e);
-		if (self.socket) self.socket.destroy();
 		if (self._interval) {
 			clearInterval(self._interval);
 			self._interval = 0;

diff --git a/test/proxy_protocol.js b/test/proxy_protocol.js
@@ -26,7 +26,7 @@ describe('ProxyProtocol', function() {
 		}
 	}
 
-	before(function (done) {
+	beforeEach(function (done) {
 		server = smpp.createServer({
 			enable_proxy_protocol_detection: true,
 		}, function (session) {
@@ -49,11 +49,12 @@ describe('ProxyProtocol', function() {
 		port = server.address().port;
 	});
 
-	after(function (done) {
+	afterEach(function (done) {
 		server.sessions.forEach(function (session) {
-			session.destroy();
+			session.close();
 		});
-		server.close(done);
+		server.close();
+		done();
 	});
 
 	it('should decode an IPv4 proxy protocol header and use it as remoteAddress', function (done) {