prevent collision on message_state TLV for query_sm_resp PDUs #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers #158
message_state is a mandatory parameter for query_sm_resp and query_broadcast_sm_resp PDU, and at the same time it is an optional parameter for other PDUs, this causes a collision on such PDUs
As this is the only optional parameter that suffers from this duplicity among optional and mandatory parameters (SMPP v5), this PR simply solves the issue by skipping the TLV for query_sm_resp and query_broadcast_sm_resp PDUs