Update view to their respective views.py #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhan-arshad-dev
changed the title
farhan-arshad-dev
force-pushed
the
structure
branch
from
e99c982
to
9d8cea8
Compare
waheedahmed
reviewed
Jul 29, 2019
.vscode/settings.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
Don't commit your local IDE files into code base, add them into git ignore.
waheedahmed
reviewed
Jul 29, 2019
farhan-arshad-dev
force-pushed
the
structure
branch
from
f5e1b12
to
7f1d0c0
Compare
|
@waheedahmed Please have a look in to it PR is ready for another pass. |
waheedahmed
reviewed
Aug 7, 2019
| from rest_framework.authentication import TokenAuthentication | ||
| from rest_framework.permissions import IsAuthenticated | ||
|
|
||
| from following_app import models as following_models |
There was a problem hiding this comment.
Import only required model classes instead of whole model module. Same in other files as well.
|
|
||
| from following_app import models as following_models | ||
| from profiles_app import permissions | ||
| from recipe_app import models as recipe_models |
There was a problem hiding this comment.
Same here Import only required model classes instead of whole model module. Same for the serializers as well.
| serializer.save(user_profile=self.request.user) | ||
|
|
||
| # override method to get user's own recipe data | ||
| def get_queryset(self): |
There was a problem hiding this comment.
I believe this should return recipes of the requesting user only and there should be a different endpoint in following app for recipes of the following users.
Rename user_profile to created_by in recipe model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update view to their respective views.py