Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admit rcopy link module missing source port and target_ip validations #8

Open
leenaj0hn opened this issue Oct 4, 2018 · 0 comments
Labels
bug Something isn't working high The bug breaks the functionality

Comments

@leenaj0hn
Copy link

Provide an invalid value in source_port": "0:3:e field, the message is should be specific to the field as is the case in 3par

Node port:
fatal: [localhost]: FAILED! => {
"changed": false,
"invocation": {
"module_args": {
"different_secondary_wwn": false,
"discard_new_data": false,
"domain": null,
"full_sync": false,
"keep_snap": false,
"local_groups_direction": false,
"local_remote_volume_pair_list": null,
"local_snap_cpg": null,
"local_user_cpg": null,
"no_resync_snapshot": false,
"no_snapshot": false,
"recovery_action": null,
"remote_copy_group_name": null,
"remove_secondary_volume": false,
"skip_initial_sync": false,
"skip_promote": false,
"skip_start": false,
"skip_sync": false,
"snapshot_name": null,
"source_port": "0:3:e",
"starting_snapshots": null,
"state": "admitlink",
"stop_groups": false,
"storage_system_ip": "192.168.67.5",
"storage_system_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
"storage_system_username": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
"target_mode": null,
"target_name": "CSSOS-SSA06",
"target_port_wwn_or_ip": "192.168.1.2",
"targets": null,
"unset_snap_cpg": false,
"unset_user_cpg": false,
"volume_auto_creation": false,
"volume_name": null
}
},
"msg": "Admit remote copy link failed | Illegal integer argument e\r"

3par output:

CSSOS-SSA05 cli% admitrcopylink CSSOS-SSA04 0:3:e:192.168.1.2
Illegal integer argument e
Error: Invalid Port number: e

@farhan7500 farhan7500 added bug Something isn't working high The bug breaks the functionality labels Oct 9, 2018
farhan7500 added a commit that referenced this issue Nov 29, 2018
* Actions for snapshot scheduling

* review and issue changes done

* more test added for schedule

* changes for snapshot name

* review changes

* action renamed

* review changes for 11 october 2018

* playbook added

* changes playbook

* changes after issue and review 12 october 2018

* final changes

* added test to increase coverage

* pep8 standard changes

* changes for pep8

* pylint changes

* new changes after issue

* pep8 fixes

* added changes for range entry for task freq interval

* pep8 fix

* message for invalid frequency changed

* modify, suspend and resume functionality added

* update

* readme changes for scheduling

* changes

* schedule added in readme.md

* changes

* state for schedule added

* Removed 3par credentials from schedule_playbook.yml

* Removed redundant schedule.yml playbook

* Worked on review comments given
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high The bug breaks the functionality
Projects
None yet
Development

No branches or pull requests

2 participants