Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(overlay): support disable overlay #1490

Merged
merged 6 commits into from
Jul 5, 2024
Merged

Conversation

fu050409
Copy link
Member

@fu050409 fu050409 commented Jul 1, 2024

Description:

Support server.hmr.overlay control overlay display

  • Add server.hmr.overlay option
  • Transfer overlay config to fronted end
  • Display overlay only when server.hmr.overlay is true

Resolved: #1262

Copy link

changeset-bot bot commented Jul 1, 2024

🦋 Changeset detected

Latest commit: 47cee4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@farmfe/runtime-plugin-hmr Patch
@farmfe/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ErKeLost
Copy link
Member

ErKeLost commented Jul 2, 2024

Thanks I will check the code later

@ErKeLost
Copy link
Member

ErKeLost commented Jul 2, 2024

Thanks,This PR may need to wait for a while. I am currently reconstructing the error handling and overlay situation. I will check this PR after it is confirmed.

@ErKeLost ErKeLost merged commit 89c4030 into farm-fe:main Jul 5, 2024
31 checks passed
@fu050409 fu050409 deleted the feat/overlay branch July 5, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: support server.hmr.overlay control overlay display
2 participants