Error assigning areas without geofields to movements

[alexadamsmith]

I've stumbled across an error in the new movement/ mapping functionality. This occurs when I add a movement to a log, or modify an existing movement. Specifically, the error popps up when add an area that lacks a geofield using the 'movement to' selector. Areas that have geofields (whether polygons, multipolygons, etc) are not affected. The error does not cause the app to crash, but the area without a geofield is not added to the movement.

`[Vue warn]: Error in v-on handler: "TypeError: Cannot read property 'geom' of undefined"

found in

---> at src/client/components/Autocomplete.vue
at src/client/components/EditLog.vue
at src/client/components/Logs.vue
at src/client/App.vue

warn @ vue.esm.js?a026:628
logError @ vue.esm.js?a026:1893
globalHandleError @ vue.esm.js?a026:1888
handleError @ vue.esm.js?a026:1848
invokeWithErrorHandling @ vue.esm.js?a026:1871
invoker @ vue.esm.js?a026:2188
invokeWithErrorHandling @ vue.esm.js?a026:1863
Vue.$emit @ vue.esm.js?a026:3891
selectSearchResult @ Autocomplete.vue?b669:82
click @ Autocomplete.vue?8338:85
invokeWithErrorHandling @ vue.esm.js?a026:1863
invoker @ vue.esm.js?a026:2188
original._wrapper @ vue.esm.js?a026:7559
vue.esm.js?a026:1897 TypeError: Cannot read property 'geom' of undefined
at VueComponent.addMovementArea (EditLog.vue?ca5d:664)
at results (EditLog.vue?f0e4:1053)
at invokeWithErrorHandling (vue.esm.js?a026:1863)
at VueComponent.invoker (vue.esm.js?a026:2188)
at invokeWithErrorHandling (vue.esm.js?a026:1863)
at VueComponent.Vue.$emit (vue.esm.js?a026:3891)
at VueComponent.selectSearchResult (Autocomplete.vue?b669:82)
at click (Autocomplete.vue?8338:85)
at invokeWithErrorHandling (vue.esm.js?a026:1863)
at HTMLLIElement.invoker (vue.esm.js?a026:2188)`

[mstenta]

Ah probably the code that automatically copies the area geometry into the map needs to fail more gracefully.

[jgaehring]

So I believe to reproduce, we need to create an area on the server, which is just a name, essentially, with no geometry assigned, then try to add that area to a movement log, is that correct, @alexadamsmith?

The problem seems to be located here: https://github.com/farmOS/farmOS-client/blob/975e16b2769d97e9a901db03bbbdd6c323b0d5bd/src/client/components/EditLog.vue#L664

Presumably just adding a null-check at that line would resolve the issue.

[mstenta]

Came across this issue myself in testing (#256 ), forgot we had an issue open for it already. :-)

Relevant from that issue:

Movements in farmOS do not require geometries. The only thing the do require is an area reference. So Field Kit needs to be able to reference an area without a geometry.

[alexadamsmith]

I can look into this one over Thanksgiving too, since I was looking into it earlier as well

[alexadamsmith]

This should take care of it

[jgaehring]

Resolved by #271.