Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prefix link fragments (#) and clear caches before each build. #32

Merged
merged 2 commits into from Jan 5, 2022

Conversation

jgaehring
Copy link
Member

This worked locally, but I had a weird runtime error that was only resolved by clearing the build cache first, so I want to see what happens in the preview build before merging.

@netlify
Copy link

netlify bot commented Jan 5, 2022

✔️ Deploy Preview for gracious-brattain-bdd606 ready!

🔨 Explore the source changes: 4ba42eb

🔍 Inspect the deploy log: https://app.netlify.com/sites/gracious-brattain-bdd606/deploys/61d5c6d06bc88f0007091878

😎 Browse the preview: https://deploy-preview-32--gracious-brattain-bdd606.netlify.app

@jgaehring
Copy link
Member Author

Weird, I'm not seeing the same runtime error, but it does not seem to have propagated the change. I'll clear the cache from Netlify and rebuild. 🤞

@jgaehring
Copy link
Member Author

Ok, clearing the cache from Netlify fixed it.

I may modify the build script to just blow away everything prior to every build. That would negate any of the optimizations Netlify/Gatsby has for fast rebuilds, but at this point I'd rather optimize for not having to go in and manually clear the cache, or worry about runtime errors getting pushed to production b/c of a cached build relic. After #16, I was trying to be conservative by only removing .cache/gatsby-source-git, but I will probably just use gatsby clean instead to make sure nothing is left over, in both the .cache or public directories.

@jgaehring
Copy link
Member Author

I may modify the build script to just blow away everything prior to every build.

I just went ahead and did this, lumping it in with this PR. Looks good on the preview build so I will merge. I'll double check to see that nothing goes afoul on the production build though, just to be sure.

@jgaehring jgaehring merged commit 4ba42eb into farmOS:main Jan 5, 2022
@jgaehring
Copy link
Member Author

I'll double check to see that nothing goes afoul on the production build though, just to be sure.

Looks good! 👍

@jgaehring jgaehring changed the title Check for # before prefixing links; resolves #31. Don't prefix link fragments (#) and clear caches before each build. Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant