Display archived animals in livestock weight report #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, here is the script I use to generate semi-realistic animal weights: https://gist.github.com/paul121/afdf1575f2d9400a2668fc36180c8d06 |
mstenta
added a commit
to mstenta/farmOS
that referenced
this pull request
Jun 1, 2020
|
Merged - thanks @paul121 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple checkbox to include archived animal assets in the weight report. Animals are displayed with
Animal Name (archived)in the result table.I also modified the Animal Groups to display archived groups, but with a label such as
Group Name (archived). I'm curious if we should only include groups that have animal assets - was there a reason we didn't do that? Simplicity?