-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically mark logs as "done" #100
Comments
Here is a pull request - is that all that's needed to make this work? https://github.com/mstenta/farmOS-client/pull/1 |
That should pretty much do it, yea! Although for good measure we probably ought to do the same in the native repo's logFactory. The defaults should all originate with the client, but just to be safe. (Letting the client and native repos share the same logFactory is another reason I'd love to get them back together as a monorepo.) |
Oh, apparently I can't merge though. Looks like you might have actually submitted the PR to your fork (mstenta/farmOS-client), not to the farmOS/farmOS-client? |
Ah ok - didn't know there was a logFactory in both. Oops - made that pull request pretty quick - wasn't paying attention I guess. I'll close that and make two new ones (in native and client). |
Awesome, thanks! |
(Transferring all issues from old repository. See #92) |
Very simple request: let's mark logs as "done" by default.
This can be done simply by setting
"done": 1
in the JSON that is sent to farmOS.The text was updated successfully, but these errors were encountered: