Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically mark logs as "done" #100

Closed
mstenta opened this issue Oct 30, 2018 · 6 comments
Closed

Automatically mark logs as "done" #100

mstenta opened this issue Oct 30, 2018 · 6 comments

Comments

@mstenta
Copy link
Member

mstenta commented Oct 30, 2018

Very simple request: let's mark logs as "done" by default.

This can be done simply by setting "done": 1 in the JSON that is sent to farmOS.

@mstenta
Copy link
Member Author

mstenta commented Oct 30, 2018

Here is a pull request - is that all that's needed to make this work? https://github.com/mstenta/farmOS-client/pull/1

@jgaehring
Copy link
Member

That should pretty much do it, yea! Although for good measure we probably ought to do the same in the native repo's logFactory. The defaults should all originate with the client, but just to be safe.

(Letting the client and native repos share the same logFactory is another reason I'd love to get them back together as a monorepo.)

@jgaehring
Copy link
Member

Oh, apparently I can't merge though. Looks like you might have actually submitted the PR to your fork (mstenta/farmOS-client), not to the farmOS/farmOS-client?

@mstenta
Copy link
Member Author

mstenta commented Oct 31, 2018

Ah ok - didn't know there was a logFactory in both.

Oops - made that pull request pretty quick - wasn't paying attention I guess. I'll close that and make two new ones (in native and client).

@jgaehring
Copy link
Member

Awesome, thanks!

@mstenta mstenta transferred this issue from farmOS-legacy/farmOS-client Feb 19, 2019
@mstenta
Copy link
Member Author

mstenta commented Feb 19, 2019

(Transferring all issues from old repository. See #92)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants