Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move core application state into the shellModule #101

Closed
jgaehring opened this issue Oct 9, 2018 · 3 comments
Closed

Move core application state into the shellModule #101

jgaehring opened this issue Oct 9, 2018 · 3 comments

Comments

@jgaehring
Copy link
Member

This would include data and bits of state that are core to the app's basic funtionality, things like whether the user was online or not, error messages, etc. A big question is whether or not user and host details would be included here, or if that would remain part of the login module. The shellModule would certainly not include data about the farm, like the data contained in logs or assets, which are all part of the farmModule in Vuex.

@jgaehring
Copy link
Member Author

Might be nice to add this bit of state back in:

const shellModule = {
  state: {
    // ...
    userInfo: {
      username: '',
      host: '',
      loggedIn: false,
    },
  },
  // ...
}

I removed this from the loginModule a while back, because it wasn't really being used, in favor of better error handling when dealing with authentication. I still think authentication and routing should be determined by handling different HTTP response codes, but this state could be useful information to surface to the user, just so they can verify which server their connected to, what user they're logged in as, etc, along with the option to login/logout.

@jgaehring
Copy link
Member Author

This has been resolved for a little while now, since at least PR #39 .

@mstenta mstenta transferred this issue from farmOS-legacy/farmOS-client Feb 19, 2019
@mstenta
Copy link
Member

mstenta commented Feb 19, 2019

(Transferring all issues from old repository. See #92)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants