Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code, unused components and duplication #116

Closed
jgaehring opened this issue Apr 27, 2018 · 2 comments
Closed

Remove dead code, unused components and duplication #116

jgaehring opened this issue Apr 27, 2018 · 2 comments

Comments

@jgaehring
Copy link
Member

We've accrued a lot of dead code already that needs to be cleaned up. Some of this simply consists of commented out code that wasn't working or superseded, as well as methods/functions that aren't being called anywhere. There is also a great deal of stub components and console.log() statements that are being used for testing purposes, but should be replaced with proper tests (see #11).

There are also a lot of components that just aren't being used (eg, Chooser.vue), and others which should probably be replaced, renamed or repurposed. For example, NewObservations.vue should be renamed EditObservations.vue so it can be used more generically. And instead of listing all observations, as Observations.vue currently does, it should be repurposed as a container component, containing the EditObservation.vue and AllObservations.vue components. AllObservations.vue should then take over the role of listing all observations, as outlined in "Modeling the Observations List").

This issue corresponds to #24.

@jgaehring jgaehring changed the title Code Quality Remove dead code and unused components Jul 18, 2018
@jgaehring jgaehring changed the title Remove dead code and unused components Remove dead code, unused components and duplication Jul 18, 2018
@jgaehring
Copy link
Member Author

This is mostly done for now. Just need to prevent more dead code from being committed to master in the future, and picking off any stragglers as we go.

@mstenta mstenta transferred this issue from farmOS-legacy/farmOS-client Feb 19, 2019
@mstenta
Copy link
Member

mstenta commented Feb 19, 2019

(Transferring all issues from old repository. See #92)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants