Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing suite to client #117

Closed
mstenta opened this issue Apr 18, 2018 · 2 comments
Closed

Add testing suite to client #117

mstenta opened this issue Apr 18, 2018 · 2 comments

Comments

@mstenta
Copy link
Member

mstenta commented Apr 18, 2018

While this project is still pretty new, I think it would be worth making automated testing a core part of the development process. This is something I wish I had done more of with farmOS itself (although farmOS sits on top of a lot of underlying components that have automated tests already), and I hope to make it a key part of the Drupal 8 upgrade initiative.

I see that Vue.js provides some tooling for this: https://vuejs.org/v2/guide/unit-testing.html

Perhaps we can get TravisCI set up with this repo, write some tests for the code we have thusfar, and then make it a part of the process moving forward (along with documentation).

What do you think?

@jgaehring
Copy link
Member

Absolutely! 💯

This has crossed my mind several times, especially in #19 where I mentioned the possibility of inadvertently breaking the code-base by removing farmos-client from farmos-native's list of dependencies. It also strikes me as particularly useful now that we have the native and client repos broken into a separate packages; it would be nice to know each works independently.

I'll look more into Vue's recommendations, as you referenced above. For the client, which no longer has it's own Webpack or other devDependencies, it might make more sense to just use Karma (or Jest or whatever) with some npm scripts for local testing, with TravisCI for some extra safety at the repository level.

It might also make sense to work on the basic setup for this in tangent with #1 (linting).

More food for thought... There a lot of console.log()statements still in the code that ideally shouldn't go into production, a lot of which I've already removed, but they might actually work as useful sign-posts for where we need to write a test.

@jgaehring jgaehring changed the title Unit testing Add testing suite to client Jul 18, 2018
@mstenta mstenta transferred this issue from farmOS-legacy/farmOS-client Feb 19, 2019
@mstenta
Copy link
Member Author

mstenta commented Feb 19, 2019

(Transferring all issues from old repository. See #92)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants