Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure ESLint so it works properly #120

Closed
mstenta opened this issue Apr 11, 2018 · 3 comments
Closed

Reconfigure ESLint so it works properly #120

mstenta opened this issue Apr 11, 2018 · 3 comments
Assignees

Comments

@mstenta
Copy link
Member

mstenta commented Apr 11, 2018

(copying this issue from the farmOS-native repo: #8)

@jgaehring's comment from that issue:

We need to do something to either reconfigure eslint, remove it entirely, or replace it with something that doesn't cause so much noise.

In my personal experience, it was throwing 15,000+ errors when vue-cli ran the dev server, burrying any useful messages from vue-cli itself. I did a sloppy fix by just disabling it in webpack.base.conf.js, but we should address this properly at some point.

A quick investigation and some trial and error with my .eslintignore file showed that most of the noise was coming from the bootstrap and jquery minified js files that were still in the root directory. This brings up another issue of cleaning out some of those unused libraries, or moving them some place where they can be more easily managed. Ideally, we should probably be pulling in any extra libs with npm anyways.

@jgaehring
Copy link
Member

This def still needs to happen... One issue with doing this in the client repo is that this repo no longer runs Wepback independently (it defers to the native repo to do that), and since we had eslint setup as a Webpack plugin, we probably want to have a separate npm script for running eslint on its own. Should be simple enough, as long as we can get it setup to work with *.vue files w/o Webpack.

Another question is what style guide we want to adopt. I'm all for adopting whatever's most prevalent and least controversial. The Airbnb style guide has been reigning king in the JS world for a while, so I support that, but am open to other suggestions. It also seems that Drupal 8 Core has adopted the Airbnb guide as its new baseline standard, which may be another plus in the Airbnb column.

@jgaehring jgaehring self-assigned this Apr 12, 2018
@mstenta
Copy link
Member Author

mstenta commented Apr 13, 2018

+1 Airbnb style guide

@jgaehring jgaehring changed the title Linting? Reconfigure ESLint so it works properly Jul 18, 2018
@mstenta mstenta transferred this issue from farmOS-legacy/farmOS-client Feb 19, 2019
@mstenta
Copy link
Member Author

mstenta commented Feb 19, 2019

(Transferring all issues from old repository. See #92)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants