Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paramaterize the DOM selector for the app's mount point #128

Closed
jgaehring opened this issue Jun 27, 2018 · 1 comment
Closed

Paramaterize the DOM selector for the app's mount point #128

jgaehring opened this issue Jun 27, 2018 · 1 comment

Comments

@jgaehring
Copy link
Member

In app.js, the main load function has #app hardcoded as the DOM selector on which the Vue app is mounted. That is, it's return value is the following Vue instance:

new Vue({
    el: '#app',
    store,
    router,
    components: {App},
    template: '<App/>'
  })

Ideally, that selector should be parameterized, so whatever implementation that's consuming the client library can decide where in the DOM to mount the app, what to name that mount point, etc, etc.

This is a pretty small issue, but I'm just leaving it here for now, because it's not necessary to the next stage of feature development on the native app, and it lies tangential to much broader issue of how to generalize the load function further, how to allow more plugins to be accepted as parameters, and whether or not to decouple Vue from the core logic of the load function. So I'm kicking this small can down the road for now.

@mstenta mstenta transferred this issue from farmOS-legacy/farmOS-client Feb 19, 2019
@mstenta
Copy link
Member

mstenta commented Feb 19, 2019

(Transferring all issues from old repository. See #92)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants