Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webpack-merge to reintegrate mobile conf files with webpack.base.conf.js #30

Closed
jgaehring opened this issue May 31, 2018 · 1 comment

Comments

@jgaehring
Copy link
Member

I went back and found the tutorial Alex used to initialize the project and setup the Webpack configuration: "Making work the Vue.js webpack template with cordova". I think I've found the problem with this setup which is leading to the duplication I mentioned in #14 (comment).

The tutorial goes against Webpack best practices by copying the webpack.base.conf.js file itself and making changes in the copy, instead of using webpack-merge. The build-mobile script then points to the copy, not the base, which is now wholly ignored, kinda defeating the purpose of a base configuration. Found a good article on using merge: "Composing Configuration".

@jgaehring
Copy link
Member Author

Merging the mobile conf wasn't strictly necessary, but this issue is resolved by /issues/8. Still a little work should be done to tidy up the native Webpack config, which can be addressed in #22 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant