Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deconstruct Autocomplete and ObjectSelector into interchangeable components #97

Closed
alexadamsmith opened this issue Jan 31, 2019 · 3 comments

Comments

@alexadamsmith
Copy link
Collaborator

Currently, we have two components in the client repo called Autocomplete and ObjectSelector which are both used for choosing objects associated with logs. Autocomplete includes a text search function, displays results, and lets you choose among them. ObjectSelector allows you to display and choosing among results of a search performed externally.
In the future, we would like to break these components into several interchangeable components. They could be something like

  • Text search component
  • Display search results component
  • Display selected results component (with deletion)
@jgaehring
Copy link
Member

I'm working on adding the ability to edit logs (#84) and came across another reason to not include the displayed selection as part of the Autocomplete/ObjectSelector component. We need to be able to display areas/assets that were already selected and added to the current log before the current editing session. That becomes really hard if you have to pass that information down to the Autocomplete component. It's more complexity that I think doesn't belong with this component.

I'm not sure that displaying selections should be its own component, but I think EditLog.vue should have direct control over displaying them, since EditLog already has all the logs as props and can therefore more cleanly render things like which areas and assets are already attached to the log.

@jgaehring
Copy link
Member

I'm closing this b/c I don't think it will be so much of an issue after refactoring Autocomplete and removing ObjectSelector.

@mstenta mstenta transferred this issue from farmOS-legacy/farmOS-client Feb 19, 2019
@mstenta
Copy link
Member

mstenta commented Feb 19, 2019

(Transferring all issues from old repository. See #92)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants