Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally mark the GitHub Action as failed if the PR isn't connected to any Clubhouse story #26

Closed
wants to merge 1 commit into from

Conversation

dnsv
Copy link
Contributor

@dnsv dnsv commented Aug 26, 2021

In my use case, not all PRs are connected to Clubhouse stories and also this step is not the last one in my workflow.

This PR adds a new variable with which one can control if the step should be marked as failed or not when the PR is not connected to any story.

@kuritz
Copy link
Member

kuritz commented Sep 16, 2021

@dnsv makes sense, we can get this merged. can i just ask that you add a test demonstrating we don't error when the option is set for that behavior?

@dnsv dnsv closed this Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants