Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) Adding built assets to dist for packaging [sc-68186] #32

Merged
merged 3 commits into from
Sep 9, 2021
Merged

(chore) Adding built assets to dist for packaging [sc-68186] #32

merged 3 commits into from
Sep 9, 2021

Conversation

zdxn
Copy link
Contributor

@zdxn zdxn commented Sep 9, 2021

Built assets.

@zdxn zdxn requested a review from kuritz September 9, 2021 16:35
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #68186: Update PR Naming Action for s/clubhouse/shortcut.

@kuritz
Copy link
Member

kuritz commented Sep 9, 2021

@zdxn looks like ncc isn't bundling deps anymore maybe? see 16,000 deletions, which is unexpected.

@zdxn
Copy link
Contributor Author

zdxn commented Sep 9, 2021

Yeah i just noticed the failure as well on the run.

@zdxn zdxn merged commit 4015e22 into master Sep 9, 2021
@zdxn zdxn deleted the zdixon/sc-68186/run-build-script branch September 9, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuritz kuritz kuritz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zdxn @kuritz