Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove python 2.7 packages #21

Merged
merged 10 commits into from
Apr 15, 2020
Merged

remove python 2.7 packages #21

merged 10 commits into from
Apr 15, 2020

Conversation

faroit
Copy link
Owner

@faroit faroit commented Oct 23, 2019

Python 2.7 will not be maintained after January 1, 2020. I would therefore propose to remove all packages that are not compatible at the end of this year.

Dear package maintainers, feel free to drop a comment here when your package is made compatible to python 3 in the meantime. I will then update this PR. Thanks for your hard work!

Python 3 (in-)compatibility list

  • NUSSL:octocat: 馃摝 - Various source separation algorithms + framework.

@ethman @pseeth

  • pyFASST:octocat: 馃摝 - Wrapper for Flexible Audio Source Separation Toolbox.

@wslihgt

@worldveil @mauriciorepetto

  • TimeSide:octocat: - high level audio analysis, imaging, transcoding, streaming and labelling.

@piem @Tointoin @yomguy

@mauricio-repetto
Copy link

@faroit hi! The pull request that I've created worldveil/dejavu#205 is to migrate dejavu 2.7 to 3.6.6. I've also added more features and solved a couple of bugs.

@faroit
Copy link
Owner Author

faroit commented Oct 23, 2019

@mauriciorepetto 馃憤 brilliant. let me know when that is merged so I can remove it from this list!

@mauricio-repetto
Copy link

That's on @worldveil :) so let's wait on him to approve and merge that.

@edudobay
Copy link

Hey @faroit! Long story short, my Mingus fork https://github.com/edudobay/python-mingus does support Python 3 now, though the original repository has been archived and I haven't heard from the original maintainer @bspaans about it.

I don't know how a case like this should be handled; if you feel that's okay and in no way disrespectful with the original maintainer, you may list my fork as a Python 3-compatible alternative to the original project.

I had submitted a PR to have Mingus support Python 3, but I had no response from the maintainer and afterwards the original repository was archived.

I've made some more changes to my fork, but I'm not actively maintaining it. Though if there's demand from the community I'd be glad to step up to being a maintainer (so that I could upload the updated version to PyPI and whatnot).

@bspaans
Copy link

bspaans commented Nov 11, 2019

Hey @edudobay, sorry for missing the great work you've been doing. I don't have any time to be involved with maintenance, hence why the repo is archived, but if you'd like I can add you as a collaborator on the project? Not sure how to handle PyPI, but I think I can either transfer or share the mingus namespace with you, so that you can upload a new release. Let me know what you think.

@edudobay
Copy link

Hey @bspaans, I'd be happy to be added as a colaborator, and I think you could share the PyPI namespace with me if that's okay. Apart from the Python 3 changes, I've made some minor changes for ease of maintenance (e.g. running the black source formatter to keep a consistent coding style). Anyway, to avoid unnecessary noise in this thread I'd suggest moving the discussion to your repo or my fork. Because this is your project and I've never taken a big contribution on someone else's project, I'd like to know if you have thoughts about how the project should be carried on.

@yomguy
Copy link

yomguy commented Dec 11, 2019

Hi!
Just to mention that TimeSide is currently in high development and then should not be removed from this list. Nevertheless, it should be listed in Music Information Retrieval rather than Web Audio.
Thanks!

@yomguy
Copy link

yomguy commented Dec 11, 2019

What about to merge Feature extraction and Music Information Retrieval lists?

@faroit
Copy link
Owner Author

faroit commented Dec 11, 2019

@yomguy

What about to merge Feature extraction and Music Information Retrieval lists?

I am not so sure about this one. Maybe better would be to create a generic audio/music processing tools section. I would probably through in aubio, timeside and essentia in that category. What do you think?

@faroit
Copy link
Owner Author

faroit commented Dec 11, 2019

Just to mention that TimeSide is currently in high development and then should not be removed from this list.

Great, as soon as you have some beta builds, keep me posted here.

@faroit
Copy link
Owner Author

faroit commented Dec 11, 2019

@edudobay @bspaans I'm okay with linking to the fork. @edudobay I would suggest you remove the "forked" status once you agreed on how to continue the project.

@yomguy
Copy link

yomguy commented Dec 12, 2019

@yomguy

What about to merge Feature extraction and Music Information Retrieval lists?

I am not so sure about this one. Maybe better would be to create a generic audio/music processing tools section. I would probably through in aubio, timeside and essentia in that category. What do you think?

Yes, this was my idea merging the two sections. I would agree with "Generic audio processing", maybe "music" should be kept for more symbolic tools not related to audio at all. And maybe leaving more specific audio tools in other sections, like "Speech processing".

@piem what do you think?

@yomguy
Copy link

yomguy commented Dec 12, 2019

Just to mention that TimeSide is currently in high development and then should not be removed from this list.

Great, as soon as you have some beta builds, keep me posted here.

OK, sure!
Thanks

@edudobay
Copy link

edudobay commented Jan 7, 2020

Hi @faroit, and a happy new year! Just dropping by to announce that a new version of Mingus has been released, with Python 3 support :)

Edit: PyPI link: https://pypi.org/project/mingus/

@faroit
Copy link
Owner Author

faroit commented Feb 16, 2020

@edudobay @bspaans thanks, modified in this PR

@faroit
Copy link
Owner Author

faroit commented Feb 16, 2020

@yomguy is there python 3 release planned for timeside soon?

@yomguy
Copy link

yomguy commented Feb 16, 2020

@yomguy is there python 3 release planned for timeside soon?

@faroit yes, the dev branch is now Python 3 ready ;)
https://github.com/Parisson/TimeSide/tree/dev

@faroit
Copy link
Owner Author

faroit commented Mar 3, 2020

okay, @yomguy I re-added timeside, marked as beta. Please drop me a note once its released

@faroit
Copy link
Owner Author

faroit commented Mar 3, 2020

@pseeth do you have a working beta version of NUSSL for python 3?

@pseeth
Copy link

pseeth commented Mar 3, 2020

It's coming! You can see the progress here: https://github.com/interactiveaudiolab/nussl/tree/refactor

I'll ping when it's pip installable - aiming for next week, hopefully.

@pseeth
Copy link

pseeth commented Apr 15, 2020

nussl is now pip installable and compatible with Python 3!

edit: If you could update the link as well to here: https://nussl.github.io/docs/, that'd be great. Thanks!

@faroit
Copy link
Owner Author

faroit commented Apr 15, 2020

@mauriciorepetto @wslihgt I am merging this now as python 2 cannot be recommended at this point. Feel free to open a PR once your packages are ready for python 3

@faroit faroit merged commit ba8d4ff into master Apr 15, 2020
@mauricio-repetto
Copy link

@faroit hi! I still don't have any reply from @worldveil, the fork that I've made is still there: worldveil/dejavu#205

@faroit
Copy link
Owner Author

faroit commented Apr 15, 2020

@mauriciorepetto @wslihgt I am merging this now as python 2 cannot be recommended at this point. Feel free to open a PR once your packages are ready for python 3

I appreciate your work. Ping me here once this has been merged

@mauricio-repetto
Copy link

@mauriciorepetto @wslihgt I am merging this now as python 2 cannot be recommended at this point. Feel free to open a PR once your packages are ready for python 3

I appreciate your work. Ping me here once this has been merged

Will do! thanks :)

@faroit faroit mentioned this pull request May 19, 2020
@faroit faroit mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants