-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stem file created with NI stem creator (mp4box) #32
Conversation
Great, thanks!
|
Yes, ALAC is supported. I used a slightly modified version of https://github.com/axeldelafosse/stemgen to generate the files. The file is bigger but it's lossless. I actually don't mind having bigger files. I guess it should be an option, we need to keep this in mind. |
Okay, I will add ALAC support to the unit tests later. For now, lets try to keep the repo-size down and just go with m4a, please |
OK. Just to be sure, you want me to replace the current |
Yep. If you want to keep m4a instead of mp4, thats also fine. In that case change the unit test paths |
Cool. Done! |
weird, this new file doesn't seem to be able to be able to get demuxed with quicklook on OSX (See #22). Maybe we need a combination the current and the new method to cover more broad playback support (quicktime, vlc, ffmpeg and traktor) |
Your file is significantly larger than the old one. Does the stem creator use different bitrate settings? (I used 256kbit CBR AAC) |
Yeah this feature can be useful! Didn't knew about it.
No it's 256kbit too: https://github.com/axeldelafosse/stemgen/blob/master/ni-stem/_internal.py#L110 Digging in, I realized that the stem creator convert each stem to I double checked and it's weird but the file is 238kbit: Your old file is 129kbit: Any idea why? |
coming back to this, i noticed that your file does not allow to switch substreams on the OSX default player (See #22). So, it looks like there are good reasons for stems created using mp4box (NI/Traktor compatibility) or ffmpeg (general better compatibility). Therefore, I want to allow mp4box optionally and not replace the ffmpeg way of exporting @axeldelafosse can you rename your exported files so we have
in addition to
Also
|
@axeldelafosse would you mind looking into this again? thanks so much! |
Yeah sure -- sorry for the delay. Can you share the MUSDB18 colors here please? |
dito ;-) the musdb18 colors are:
|
Here we go |
the file is included in #28 . closing this out now |
Compatible with Traktor: