Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stem file created with NI stem creator (mp4box) #32

Closed
wants to merge 4 commits into from

Conversation

axeldelafosse
Copy link

Compatible with Traktor:

Screen Shot 2020-06-06 at 2 59 50 PM

Screen Shot 2020-06-06 at 3 01 45 PM

@faroit
Copy link
Owner

faroit commented Jun 6, 2020

Great, thanks!

  • Lets try replacing the existing m4a and see if stempeg unit tests still run.
  • Conerning ALAC, is it supported on traktor?

@axeldelafosse
Copy link
Author

Yes, ALAC is supported. I used a slightly modified version of https://github.com/axeldelafosse/stemgen to generate the files. The file is bigger but it's lossless. I actually don't mind having bigger files. I guess it should be an option, we need to keep this in mind.

@faroit
Copy link
Owner

faroit commented Jun 6, 2020

Okay, I will add ALAC support to the unit tests later. For now, lets try to keep the repo-size down and just go with m4a, please

@axeldelafosse
Copy link
Author

OK. Just to be sure, you want me to replace the current stem.mp4 file with the new stem.m4a aac file?

@faroit
Copy link
Owner

faroit commented Jun 6, 2020

Yep. If you want to keep m4a instead of mp4, thats also fine. In that case change the unit test paths

@axeldelafosse axeldelafosse changed the title Add stems created with NI stem creator (mp4box, acc + alac) Add stem file created with NI stem creator (mp4box) Jun 6, 2020
@axeldelafosse
Copy link
Author

Cool. Done!

@faroit
Copy link
Owner

faroit commented Jun 6, 2020

weird, this new file doesn't seem to be able to be able to get demuxed with quicklook on OSX (See #22). Maybe we need a combination the current and the new method to cover more broad playback support (quicktime, vlc, ffmpeg and traktor)

@faroit
Copy link
Owner

faroit commented Jun 6, 2020

Your file is significantly larger than the old one. Does the stem creator use different bitrate settings? (I used 256kbit CBR AAC)

@axeldelafosse
Copy link
Author

axeldelafosse commented Jun 6, 2020

weird, this new file doesn't seem to be able to be able to get demuxed with quicklook on OSX (See #22). Maybe we need a combination the current and the new method to cover more broad playback support (quicktime, vlc, ffmpeg and traktor)

Yeah this feature can be useful! Didn't knew about it.

Your file is significantly larger than the old one. Does the stem creator use different bitrate settings? (I used 256kbit CBR AAC)

No it's 256kbit too: https://github.com/axeldelafosse/stemgen/blob/master/ni-stem/_internal.py#L110

Digging in, I realized that the stem creator convert each stem to .m4a using afconvert before creating the file with mp4box.

I double checked and it's weird but the file is 238kbit:

Screen Shot 2020-06-06 at 9 28 31 PM

Your old file is 129kbit:

Screen Shot 2020-06-06 at 9 53 21 PM

Any idea why?

@faroit
Copy link
Owner

faroit commented Sep 2, 2020

coming back to this, i noticed that your file does not allow to switch substreams on the OSX default player (See #22). So, it looks like there are good reasons for stems created using mp4box (NI/Traktor compatibility) or ffmpeg (general better compatibility). Therefore, I want to allow mp4box optionally and not replace the ffmpeg way of exporting

@axeldelafosse can you rename your exported files so we have

  • data/The Easton Ellises - Falcon 69.mp4box.stem.m4a

in addition to

  • data/The Easton Ellises - Falcon 69.ffmpeg.stem.m4a

Also

  • can you add the MUSDB18 colors to the stems if possible?

@faroit
Copy link
Owner

faroit commented Sep 16, 2020

@axeldelafosse would you mind looking into this again? thanks so much!

@axeldelafosse
Copy link
Author

Yeah sure -- sorry for the delay. Can you share the MUSDB18 colors here please?

@faroit
Copy link
Owner

faroit commented Oct 4, 2020

Yeah sure -- sorry for the delay. Can you share the MUSDB18 colors here please?

dito ;-)

the musdb18 colors are:

vocals #56B4E9
drums #009E73
bass #D55E00
other #CC79A7

@axeldelafosse
Copy link
Author

Here we go

@faroit faroit mentioned this pull request Oct 25, 2020
@faroit
Copy link
Owner

faroit commented Oct 25, 2020

the file is included in #28 . closing this out now

@faroit faroit closed this Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants