Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source and connection for all supported sources in Airbyte #196

Merged
merged 7 commits into from Jul 8, 2022

Conversation

thomas-gerber
Copy link
Contributor

@thomas-gerber thomas-gerber commented Jul 7, 2022

Description

All supported sources now have a canned source and a corresponding connection to the Faros destination in Airbyte.

Related to #195

Screen Shot 2022-07-07 at 4 42 38 PM

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • Have you checked to there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@thomas-gerber thomas-gerber changed the title Add all connections Add source and connection for all supported sources in Airbyte Jul 7, 2022
@thomas-gerber
Copy link
Contributor Author

Documentation is up-to-date: https://community.faros.ai/docs/supported-sources

@ypc-faros
Copy link
Contributor

nit: Do we want to also sort the sources as we did the connections
Screen Shot 2022-07-08 at 8 42 44 AM
?

@ypc-faros
Copy link
Contributor

I see you added the "Faros Feeds" source to init/resources/airbyte/workspace/airbyte_config/STANDARD_SOURCE_DEFINITION.yaml but it doesn't show up in the sources tab and there's no connection set up with that source. Is that intentional?

@thomas-gerber
Copy link
Contributor Author

I see you added the "Faros Feeds" source to init/resources/airbyte/workspace/airbyte_config/STANDARD_SOURCE_DEFINITION.yaml but it doesn't show up in the sources tab and there's no connection set up with that source. Is that intentional?

Yes. Keeping the GH fork for now as it messes up some dashboards.

@thomas-gerber
Copy link
Contributor Author

nit: Do we want to also sort the sources as we did the connections Screen Shot 2022-07-08 at 8 42 44 AM ?

The sources are sorted in the files, it is unclear to me how they are sorted in the UI, and ordering seems to change based on actions you take.
The connections screen has some sorting capabilities (source, or destination).

@thomas-gerber thomas-gerber merged commit c84aede into main Jul 8, 2022
@thomas-gerber thomas-gerber deleted the add_all_connections branch July 8, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants